aacid added a comment.
The magic to generate sip files was not magic enough
https://phabricator.kde.org/D18345
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D18137
To: aacid, mpyne
Cc: cgiboudeaux, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns
cgiboudeaux added a comment.
This is causing an error when building the python bindings:
> In file included from
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/unifiedKCoreAddons.cpp:15:
>
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKdeli
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:44b91ba50d2f: delete copy constructor and assignment
operator of some public classes (authored by aacid).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18137?v
aacid added a comment.
I did some grepping and didn't find anything obvious (which make sense since
it would be crashy)
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18137
To: aacid, mpyne
Cc: mpyne, kde-frameworks-devel, michaelh, ngraham, br
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
The KSharedDataCache change is definitely correct. I've not done much with
the kdelibs migrator but I agree with the logic and the implementation. Have
you tried building some of the other fr
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.
