D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. In D18114#498642 , @romangg wrote: > @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about

D18114: FakeInput: add support for pointer move with absolute coordinates

romangg added a comment. @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can have

D18114: FakeInput: add support for pointer move with absolute coordinates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move with absolute coordinates (authored by jgrulich). REPOSITORY R

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson accepted this revision. davidedmundson added a comment. Given we have absolute events for other input, this makes sense. Ship it REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zz

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Ping @graesslin? Martin, can you please look into this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Hi, can I get please this re-approved? It's now just again about the additional mouse support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, m

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49133. jgrulich added a comment. Drop keyboard support from this review REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49087&id=49133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AF

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release" to "FakeInput: add support for pointer move with absolute coordinates". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION D

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I'm the author of this interface and I consider it nowadays as a mistake to have added it. If I would restart I would do the whole thing differently: input events need to be injected through a kernel module in a dedicated input device. It would need a user space co

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I don't want to have key press/release in it. It has a reason that I didn't add key press/release from the start. The problem is the mismatch of key events and keysyms. Especially the kdeconnect use case for which this interface was developed has this problem. Andr

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich updated this revision to Diff 49087. jgrulich added a comment. Fix documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49082&id=49087 BRANCH fake-input-keyboard-key REVISION DETAIL https://phabricator.kde.org/D18114 AFFECT

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich added a comment. I didn't intent to push this together, but when creating a branch from master which already had first round of changes caused my second part of changes to be pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to get exception from David Faure

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

jgrulich retitled this revision from "FakeInput: add support for pointer move with absolute coordinates" to "FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release". jgrulich edited the summary of this revision. REPOSITORY R127 KWayland REVISION D

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49082. jgrulich added a comment. Add support for keyboard key press and release REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49081&id=49082 BRANCH fake-input-keyboard-key REVISION DETAIL https://phabr

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49081. jgrulich added a comment. Bump fake interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49071&id=49081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILE

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49071. jgrulich added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49070&id=49071 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES autotests/c

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added inline comments. INLINE COMMENTS > fakeinput.cpp:106 > +Q_ASSERT(d->manager.isValid()); > +if (wl_proxy_get_version(d->manager) < > ORG_KDE_KWIN_FAKE_INPUT_POINTER_MOTION_ABSOLUTE_SINCE_VERSION) > +return; Use curly braces even when the bo

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49070. jgrulich added a comment. Fix review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49069&id=49070 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES auto

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:86 > > + > + since="3" REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraha

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson accepted this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49069. jgrulich added a comment. Adress review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49066&id=49069 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFFECTED FILES a

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson added inline comments. INLINE COMMENTS > fakeinput.cpp:106 > +Q_ASSERT(d->manager.isValid()); > +org_kde_kwin_fake_input_pointer_motion_absolute(d->manager, > wl_fixed_from_double(pos.x()), wl_fixed_from_double(pos.y())); > +} if (wl_proxy_get_version(d->manager) < ORG_K

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag accepted this revision. zzag added a comment. Please wait for @davidedmundson and @graesslin. :-) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, b

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49066. jgrulich added a comment. Add information when new methods were introduced and bump version of FakeInput in registry REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49064&id=49066 BRANCH master REV

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput_interface.cpp:164 > + > + > void FakeInputInterface::Private::axisCallback(wl_client *client, > wl_resource *resource, uint32_t axis, wl_fixed_t value) Please delete one extra empty line. REPOSITORY R127 KWayland REVISION DETAIL htt

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added a comment. maxVersion in src/client/registry.cpp should be updated as well. INLINE COMMENTS > fakeinput.h:138 > + * Request an absolute pointer motion to @p pos position. > + **/ > +void requestPointerMoveAbsolute(const QPointF &pos); Missing `@since`. > fakeinput_int

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49064. jgrulich added a comment. Revert unwanted changes in CMakeLists REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49046&id=49064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18114 AFF

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49046. jgrulich added a comment. Use QPointF instead of QSizeF and bump interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49028&id=49046 BRANCH master REVISION DETAIL https://phabricator.

D18114: FakeInput: add support for pointer move with absolute coordinates

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fake-input.xml:44 > > + > + New requests can only be added at end. Since is missing. > fakeinput_interface.cpp:85 > pointe

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput.h:139 > + **/ > +void requestPointerMoveAbsolute(const QSizeF &pos); > /** Wouldn't QPointF be a better choice? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc:

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:19 >]]> > > Version of the interface has to be bumped. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: zzag, kde-frameworks-devel, michaelh, ngraham, b

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a dependent revision: D18115: Add support for fake pointer move with absolute coordinates. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a reviewer: davidedmundson. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY For remote desktop support, we need to move with the pointer using absolute position. TEST PLAN I tested this with