D17956: DocumentPrivate: Fix broken doc links in qCWarning

cullmann closed this revision. cullmann added a comment. Fixed links got commited in meantime: commit b64681408d840880c7625543992cc6a75535944a Author: Grzegorz Szymaszek Date: Thu Jan 10 08:42:46 2019 +0100

D17956: DocumentPrivate: Fix broken doc links in qCWarning

ltoscano resigned from this revision. ltoscano added a comment. This revision is now accepted and ready to land. Fine by me regarding the change; I can't answer to the question whether the warning should be localized or not (maybe not), so I'm resigning from the review to not block it REVISI

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar updated this revision to Diff 48671. loh.tar added a comment. Requested modified link CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17956?vs=48655&id=48671 REVISION DETAIL https://phabricator.kde.org/D17956 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #kt

D17956: DocumentPrivate: Fix broken doc links in qCWarning

cullmann added a reviewer: dhaumann. cullmann added a comment. Should we perhaps just remove that message and keep the old compat code without any hint here? I think it doesn't hurt to just have the few extra checks "forever". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabrica

D17956: DocumentPrivate: Fix broken doc links in qCWarning

pino added a comment. Also, I do not understand why a console warning is translated: normal users will not see it, and if they do the message is not actionable for them. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To: loh.tar, #ktexteditor, sars, ltosca

D17956: DocumentPrivate: Fix broken doc links in qCWarning

ltoscano requested changes to this revision. ltoscano added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > katedocument.cpp:4592 > "Please replace with > 'remove-trailing-spaces modified;', see " > -

D17956: DocumentPrivate: Fix broken doc links in qCWarning

sars added a comment. Adding as a warning message in the view could be another review and needs comments from others first REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To: loh.tar, #ktexteditor, sars Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor,

D17956: DocumentPrivate: Fix broken doc links in qCWarning

sars accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To: loh.tar, #ktexteditor, sars Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullman

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar added a comment. How about to change this logging into a warning message in the view? Or will it displayed(?) I have noticed these while investigating https://bugs.kde.org/show_bug.cgi?id=397956 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To:

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956