D17863: Add ecm_check_linker_flags function

tcberner abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

apol added a comment. Yep, I'd say let's get it in kstars and if other applications start needing it, we move it to ECM to share. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-d

D17863: Add ecm_check_linker_flags function

cgiboudeaux added a comment. In D17863#384229 , @tcberner wrote: > In D17863#384145 , @cgiboudeaux wrote: > > > Why not fixing kstars instead? > > > > > include(ECMCheckLinkerFlags) >

D17863: Add ecm_check_linker_flags function

tcberner added a comment. In D17863#384145 , @cgiboudeaux wrote: > Why not fixing kstars instead? include(ECMCheckLinkerFlags) [...] # Check for nodump support SET(NODUMP_FLAGS "-Wl,-z,nodump") ecm_check_linker_fla

D17863: Add ecm_check_linker_flags function

cgiboudeaux added a comment. Why not fixing kstars instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner added a comment. See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

tcberner created this revision. tcberner added reviewers: FreeBSD, dfaure, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY kstars appends '-Wl,-z,nodump' to the