D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. Um, this patch sucks, sorry! Will try again or re-open bug report :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktex

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann added a comment. Diffs like: - /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.12/autotests/input/indent/cstyle/openpar12/expected 2019-03-04 16:49:58.559736000 + +++ /usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.12/autot

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Unfortunately that kills some indenter tests. https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/47/ REPOSITORY R39 KTextEditor REVISION DETAIL h

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

This revision was automatically updated to reflect the committed changes. Closed by commit R39:65e3b5462f1c: DocumentPrivate: Don't scroll view when add auto-bracket at end of file (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phab

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I can not reproduce this, but I think one setCursorPosition less is always good :P REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktex

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. > But on the other side: how does one reproduce this? Hm, I had just follow the descriptions in the report. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel, kde-fram

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

cullmann added a comment. Extra setCursor calls are always fishy. But on the other side: how does one reproduce this? For me, if I scroll behind the last line, close to any editing action triggers scrolling, with or without this patch. REPOSITORY R39 KTextEditor REVISION DETAIL

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. In D17857#383865 , @dhaumann wrote: > Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I don't think so. Here is it auto-bracket stuff, there general "is visible" stuff :-) (Yeah, my English ro

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

dhaumann added a comment. Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I once tried to fix 306745 but had to revert due to a regression, see D10054 . REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. As always poor tested and only in "normal mode", not vi INLINE COMMENTS > katedocument.cpp:3073 > const auto insertedAt(view->cursorPosition()); > -view->setCursorPosition(cursorPos); > m_currentAutobraceRange.reset(ne

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at aned of file" to "DocumentPrivate: Don't scroll view when add auto-bracket at end of file". loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://pha