dhaumann closed this revision.
dhaumann added a comment.
Closed, see commit 1e0ace28c795cbe5e88bc1f31ea37a250cd110b0
REVISION DETAIL
https://phabricator.kde.org/D17852
To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,
ngraha
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Good patch, and works for me.
REVISION DETAIL
https://phabricator.kde.org/D17852
To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, ha
loh.tar updated this revision to Diff 49530.
loh.tar added a comment.
Add autotest
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17852?vs=48340&id=49530
REVISION DETAIL
https://phabricator.kde.org/D17852
AFFECTED FILES
autotests/src/kateview_test.cpp
autotests/src/kateview_t
loh.tar added a comment.
Nice trick ;-) Can't promise to do it, will see
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17852
To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,
ngraham, bruns, demsking, cull
dhaumann added a comment.
I think this change makes sense.
I would like to have a unit test for this. Doing so is simple: Add a function
in autotest/src/kateview_test.h/cpp and add one bracket matching call, then
check the new cursor position. Then, do the same in overwrite mode.
REPOSI
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
BUG: 402594
REPOSITORY
R39 KTextEditor
REVISION DETAIL
ht
