D17623: Add YaST and new preference icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9de855e093c8: Add YaST and new preference icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48418&id=48505 REVISION DETAIL

D17623: Add YaST and new preference icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ship it! Thanks for your patience with this. The new icons look fantastic. I can't wait to use some of them in our apps' settings windows. REPOSITORY R266 Breeze Icons BRANCH yast-ic

D17623: Add YaST and new preference icons

ndavis added a comment. The patch now passes the scalable test, but I don't think it's organized in a great way. I supposed I can always reorganize things if I make 48px versions of each YaST icon later. I can't do that now because it would take way too much time and I'm starting to get sick

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48418. ndavis added a comment. Move all YaST icons that don't have a 48px version to `preferences/32/`, undo all changes to `index.theme`, remove the new `preferences-system` icon, change `yast-system` to a symlink to `systemsettings` REPOSITORY R266 Br

D17623: Add YaST and new preference icons

ngraham added a comment. Found one more issue: By creating a new version of `preferences-system` that looks different from the existing version, System Settings gets the wrong icon: F6515130: Screenshot_20181229_124318.png F6515133: Screenshot_

D17623: Add YaST and new preference icons

rooty added a comment. +1 for the icons, really nice icons REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: rooty, sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis added a comment. > (again, not taking size constraints into consideration) This is what is wrong with the test. I've set the size constraints for apps/32 to not overlap with apps/48, so there should be no problem. apps/48 does overlap with apps/64, but apps/64 isn't that important

D17623: Add YaST and new preference icons

ngraham added a subscriber: sitter. ngraham added a comment. @sitter added the test in 7d01f3d8b5c0f2c9dc6014e8e04ba5701804fec2 . Maybe he can shed some light on the best course of action here. Pertinent quote fro

D17623: Add YaST and new preference icons

ndavis added a comment. OK, so it seems I can't have multiple scalable directories with different versions of the same icon when the directories have the Application context. This test is such a pain in the ass. I know most tests are there for a good reason, but this one has only ever gotten

D17623: Add YaST and new preference icons

ngraham added a comment. Look in `Testing/Temporary/LastTest.log` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383392 , @ngraham wrote: > With the latest change, this now fails the `scalable` test. How do I see what tests a patch will pass or fail? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabrica

D17623: Add YaST and new preference icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. With the latest change, this now fails the `scalable` test. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik

D17623: Add YaST and new preference icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48332. ndavis added a comment. Add most recent changes to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48331&id=48332 BRANCH yast-icons (branched from master) REVISION DETAIL https://pha

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48331. ndavis added a comment. fix yast-installation REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48329&id=48331 BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/

D17623: Add YaST and new preference icons

ndavis added a comment. F6513963: Screenshot_20181228_223854.png I'm guessing I'll need to either do manual edits in the XML or recreate them from scratch. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL

D17623: Add YaST and new preference icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. How strange, you're right! I never noticed that. Oh well, material for another patch I suppose... REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETA

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383376 , @ngraham wrote: > Outstanding. Only one final issue that I can see: the long shadow cast by the arrow in `yast-installation` doesn't fade out; it just continues off the rest of the icon: > > F651396

D17623: Add YaST and new preference icons

ngraham added a comment. Outstanding. Only one final issue that I can see: the long shadow cast by the arrow in `yast-installation` doesn't fade out; it just continues off the rest of the icon: F6513961: Screenshot_20181228_203322.png REPOSITORY

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48329. ndavis added a comment. Shift servers in dhcp and dns server icons to the right a bit and fix the shadow of the services icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48297&id=48329 BRANCH

D17623: Add YaST and new preference icons

hellcp added a comment. That happens in Inkscape and other renderers with uneven (133%, 146% etc) magnification. When rendering also sometimes you will get a darker border when there is something dark behind an object. I used that to my advantage with new YaST Package Management icons F

D17623: Add YaST and new preference icons

ndavis added a comment. Here's the same icon in cuttlefish, except the line you saw on the bottom doesn't show up for me: F6513637: Screenshot_20181228_180802.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383325 , @ngraham wrote: > A few more little nitpicks: > > - `preferences-system-services` still has a shadow over the background rather than another part of itself: F6513586: shadow.png

D17623: Add YaST and new preference icons

ngraham added a comment. A few more little nitpicks: - `preferences-system-services` still has a shadow over the background rather than another part of itself: F6513586: shadow.png - All the the `preferences-system-network-server-*` icons have a l

D17623: Add YaST and new preference icons

ngraham added a comment. `preferences/32/preferences-system-network-dsl.svg` and `preferences/32/preferences-system-network-ethernet.svg` are now very slightly different from the device icon versions. :) They have a bottom shadow, while the new device versions you just commitetd do not. Is t

D17623: Add YaST and new preference icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48297. ndavis added a comment. Change apps/32 to scalable and add apps/64 in index.theme REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48277&id=48297 BRANCH yast-icons (branched from master) REVISION D

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#382989 , @ngraham wrote: > In D17623#382912 , @ndavis wrote: > > > We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks

D17623: Add YaST and new preference icons

ngraham added a comment. In D17623#382912 , @ndavis wrote: > We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks to preferences icons, but that doesn't fix the fact that this patch can't pass the sc

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48277. ndavis retitled this revision from "Add YaST icons" to "Add YaST and new preference icons". ndavis added a comment. Change most `yast-*` icons to symlinks and create preference icons to use as `yast-*` icons REPOSITORY R266 Breeze Icons CHANGES