D17500: Get mobipocket extractor up-to-date, but keep disabled

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:7b9cb48d95e4: Get mobipocket extractor up-to-date, but keep disabled (authored by astippich). CHANGED PRIOR TO COMMIT

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich updated this revision to Diff 61690. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17500?vs=55848&id=61690 BRANCH mobi REVISION DETAIL https://phabricator.kde.org/D17500 AFFECTED FILES CMakeLists

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. since this code is not compiled, I will merge it next week if noone objects REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, sbergeron,

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. @bruns okay for you to merge this one? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spo

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. Sure, this code is not compiled, if you think it's better just commit it (IMHO, not kfilemedata specialist) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. And I propose a different one :) IMHO bundling these two is sub-optimal as it creates an unnecessary dependency on kde-specific libraries and limits its deployment. To me, this is the equivalent of bundling the audio thumbnailer with taglib. Well, if we disag

D17500: Get mobipocket extractor up-to-date, but keep disabled

ltoscano added a comment. The proposed solution to remove the loop is moving the extractor to the kdegraphics-mobipocket repository. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel,

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. It creates a dependency loop as you pointed out in the first comment REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, ashaposhniko

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. In D17500#447620 , @astippich wrote: > In D17500#447049 , @aacid wrote: > > > In D17500#446937 , @astippich wrote: > > > > > The

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. In D17500#447049 , @aacid wrote: > In D17500#446937 , @astippich wrote: > > > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and re

D17500: Get mobipocket extractor up-to-date, but keep disabled

aacid added a comment. In D17500#446937 , @astippich wrote: > The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich added a comment. The plan I was about to propose is to move the thumbnailer to kdegraphics-thumbnailers and remove it from the QMobipocket library, lifting the KIO dependency of QMobipocket. I think a KIO dependency for such a library is inconvenient. REPOSITORY R286 KFileMetaDa

D17500: Get mobipocket extractor up-to-date, but keep disabled

ltoscano added a comment. So no plans for moving it to kdegraphics-mobipocket? It's a dependency loop. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, ashap

D17500: Get mobipocket extractor up-to-date, but keep disabled

astippich retitled this revision from "Restore mobipocket extractor" to "Get mobipocket extractor up-to-date, but keep disabled". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano