D17419: Add view-private icon

ndavis added a comment. Here's a rough draft of something similar to the F710 , but with colors that are more similar to the original DualShock controller and white Xbox 360 controller: 100% F6468233: Screenshot_20181210_062352.png

D17419: Add view-private icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b849a63cefb3: Add view-private icon (authored by GB_2, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47147&id=47205 REVISION

D17419: Add view-private icon

drosca added a comment. In D17419#374064 , @ngraham wrote: > Ah yeah, I guess that makes sense. > > #falkon folks, is this acceptable? Yes, looks great! REPOSITORY R266 Breeze Icons REVISIO

D17419: Add view-private icon

ngraham accepted this revision. ngraham added a comment. Ah yeah, I guess that makes sense. #falkon folks, is this acceptable? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon,

D17419: Add view-private icon

ndavis added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? I think the whole *-symbolic thing is a GNOME-ism. It's their way of specifying whether to

D17419: Add view-private icon

GB_2 added a comment. In D17419#373590 , @ngraham wrote: > If view-private-symbolic is just a symlink to the regular icon, do we really need it? It's for compatibility, because other icons in Breeze and also other icon themes do it. REP

D17419: Add view-private icon

ngraham added a comment. If view-private-symbolic is just a symlink to the regular icon, do we really need it? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-framewo

D17419: Add view-private icon

GB_2 updated this revision to Diff 47147. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons (wider hat brim). It's perfect now :-) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47145&id=47147 REVISION DETAIL h

D17419: Add view-private icon

GB_2 added a comment. I think I'll leave it how it is. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky2

D17419: Add view-private icon

GB_2 added a comment. Wait, but I thought if the hat brim is wider, the margins are not big enough? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #

D17419: Add view-private icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks right. I might prefer a wider hat brim or a mask like @filipf suggested, but I'm not going to make that a requirement since it seems more like a matter of taste. Here's roughly h

D17419: Add view-private icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon, ngraham, ndavis Cc: ndavis, filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, croz

D17419: Add view-private icon

GB_2 updated this revision to Diff 47145. GB_2 retitled this revision from "Add private-mode icon" to "Add view-private icon". GB_2 added a comment. Change name to the more common "view-private" and add a symlink for the symbolic icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDAT