This revision was automatically updated to reflect the committed changes.
Closed by commit R39:bb5f34d7224d: Fix hidden languages in the mode menu
(authored by nibags, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17083?vs=45975&id=
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
REPOSITORY
R39 KTextEditor
BRANCH
fix-hidden-modes
REVISION DETAIL
https://phabricator.kde.org/D17083
To: nibags, #ktexteditor, cullmann
Cc: cullmann, dhauma
nibags updated this revision to Diff 45975.
nibags added a comment.
- Update comment
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17083?vs=45972&id=45975
BRANCH
fix-hidden-modes
REVISION DETAIL
https://phabricator.kde.org/D17083
AFFECTED FILES
dhaumann added inline comments.
INLINE COMMENTS
> katemodemanager.cpp:103
> for (int i = 0; i < modes.size(); ++i) {
> // filter out None hl, we add that later as "normal" mode
> +if (modes[i].isHidden() || modes[i].name() == QLatin1String("None"))
> {
Now the comment is w
nibags added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17083
To: nibags, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,
cullmann, sars, dhaumann
nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
In the status bar, the syntax highlighting menu (mode menu) shows hidden
languages, for example: