D17052: Simplify reference counting of FrameData

apol closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks, zzag Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks, zzag Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

apol updated this revision to Diff 46026. apol added a comment. Change destructor REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17052?vs=45893&id=46026 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17052 AFFECTED FILE

D17052: Simplify reference counting of FrameData

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > zzag wrote in framesvg.cpp:569 > Do we really need to pass a shared pointer? Wouldn't it better to just pass a > raw pointer? We won't do any ownership-related stuff anyway. It doesn't really make a difference

D17052: Simplify reference counting of FrameData

mart added a comment. after adressing zzag's comments, is good to go for me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

mart added a comment. things like https://bugs.kde.org/show_bug.cgi?id=398854 i guess REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

zzag added a comment. In gneral, +1 for shared pointers. INLINE COMMENTS > framesvg.cpp:375 > //#define DEBUG_FRAMESVG_CACHE > FrameSvgPrivate::~FrameSvgPrivate() > +{} = default; > framesvg.cpp:569 > > -QRect FrameSvgPrivate::contentGeometry(FrameData* frame, const QSize& size) > cons

D17052: Simplify reference counting of FrameData

apol added a comment. In D17052#363101 , @zzag wrote: > > as it can change sometimes and crash the system. > > Could you please provide example when it can crash? Not really, it would crash mostly on complex plasmoids like taskmanager

D17052: Simplify reference counting of FrameData

zzag added a comment. > as it can change sometimes and crash the system. Could you please provide example when it can crash? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: zzag, kde-frameworks-devel, m

D17052: Simplify reference counting of FrameData

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Leverages QSharedPointer for the reference counting. Keeps the last value of the c