cgiboudeaux added a comment.
Done. kfilemetadata was also changed to use FindLibExiv2.cmake.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D17044
To: cgiboudeaux, apol, dfaure
Cc: kossebau, rempt, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,
cgiboudeaux added inline comments.
INLINE COMMENTS
> kossebau wrote in FindExiv2.cmake:31
> Could you not already do this now, before it's first released?
>
> Any potential users currently have their own copy, they will not use this
> version.
> Once they switch to rely on the version provided
kossebau added inline comments.
INLINE COMMENTS
> FindExiv2.cmake:31
> +# Since 5.53.0.
> +# TODO KF6: Rename to FindLibExiv2.cmake
> +#
Could you not already do this now, before it's first released?
Any potential users currently have their own copy, they will not use this
version.
Once they s
cgiboudeaux closed this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D17044
To: cgiboudeaux, apol, dfaure
Cc: rempt, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17044
To: cgiboudeaux, apol, dfaure
Cc: rempt, kde-frameworks-devel, kde
rempt added a comment.
Wow...
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D17044
To: cgiboudeaux, apol, dfaure
Cc: rempt, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
cgiboudeaux created this revision.
cgiboudeaux added reviewers: apol, dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
cgiboudeaux requested review of this revision.
REVISION SUMMARY
According to lxr, we have 8 copies of th
