D16905: Add new generic sorting icons; rename existing sorting icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:64b3a8fa6ff7: Add new generic sorting icons; rename existing sorting icons (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabrica

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I will land this now. There's nothing left that needs to be done. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. In D16905#361148 , @trickyricky26 wrote: > Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on each

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 updated this revision to Diff 45689. trickyricky26 added a comment. - Change margins to 4px in 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45684&id=45689 BRANCH add-sort-options-icon (branched from master) REVIS

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 added a comment. Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on each size. So that graphic should be updated, or if the 4px margins only apply to acti

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. The margins on the 32px icons are different from other 32px icons. The existing ones use a 4px margin on each side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 updated this revision to Diff 45684. trickyricky26 added a comment. - Remove old sort.svg icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45667&id=45684 BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 added a comment. That was not supposed to be there anymore after we changed the name. I'm going to remove `sort.svg` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. `sort.svg` uses the older version of your style. Make it a relative symlink to `view-sort.svg`. F6429080: Screenshot_20181117_130528.png

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. Great! That will work. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michae

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 retitled this revision from "Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme" to "Add new generic sorting icons; rename existing sorting icons". REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISIO