This revision was automatically updated to reflect the committed changes.
Closed by commit R286:9c58ae5b4800: [KFileMetaData] Add extractor for generic
XML and SVG (authored by bruns).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16489?vs=44645&id=4465
astippich accepted this revision.
astippich added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> bruns wrote in xmlextractor.cpp:24
> qCDebug(...) ...
I think that gets pulled in via "kfilemetadata_debug.h", but nevermind
REPOSITORY
R286 KFileMetaData
REV
bruns marked 2 inline comments as done.
bruns added inline comments.
INLINE COMMENTS
> astippich wrote in xmlextractor.cpp:24
> seems unused
qCDebug(...) ...
> xmlextractor.cpp:48
> +} else if (node.localName() == QLatin1String("text")) {
> +qCDebug(KFILEMETADATA_LOG) << node.text()
bruns updated this revision to Diff 44645.
bruns marked an inline comment as done.
bruns added a comment.
Reorder mimetype check to use SVG(+XML) special case if applicable and use
generic implementation for all other mimetypes inheriting from
application/xml.
Use static QStringList for m
astippich requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16489
To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngra
astippich added inline comments.
INLINE COMMENTS
> xmlextractor.cpp:24
> +
> +#include
> +#include
seems unused
> xmlextractor.cpp:27
> +#include
> +#include
> +
same
> xmlextractor.cpp:71
> +
> +return list;
> +}
Can we agree on using a static qstringlist if the mimetypes are fixed?
bruns added a dependent revision: D16490: [KFileMetaData] Add unittest for XML
extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D16489
To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraha
bruns created this revision.
bruns added reviewers: Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Currently, both XML and SVG documents are indexed as plain text du
