D15491: [Bookmarks Runner] Remove BuildQuery Functor class

2018-09-13 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R120:531d7d2c9068: [Bookmarks Runner] Remove BuildQuery Functor class (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15491?vs=41585&id=4159

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

2018-09-13 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R120 Plasma Workspace BRANCH simplify_query REVISION DETAIL https://phabricator.kde.org/D15491 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

2018-09-13 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH simplify_query REVISION DETAIL https://phabricator.kde.org/D15491 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

2018-09-13 Thread Stefan Brüns
bruns added a dependency: D15490: [Bookmarks Runner] Remove unused database parameter from query. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15491 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, a

D15491: [Bookmarks Runner] Remove BuildQuery Functor class

2018-09-13 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Instead of constructing the query string on each favicon fetch just use the (fixed) sql query stri