D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:6a35a902c969: Paint code folding marker only for multiline code folding regions (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15485?vs=41

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. +1 ;=) My fault during porting :P REPOSITORY R39 KTextEditor BRANCH fix-code-folding-markers (branched from master) REVISION DETAIL https://phabricator.kde.org/D15485 To: d

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Dominik Haumann
dhaumann updated this revision to Diff 41569. dhaumann added a comment. Correct patch as discussed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15485?vs=41567&id=41569 BRANCH fix-code-folding-markers (branched from master) REVISION DETAIL https:/

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Christoph Cullmann
cullmann added a comment. The hash update in katehighlight.cpp is the issue, Dominik has a fix for that now ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15485 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bru

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Dominik Haumann
dhaumann added a comment. Btw, this is a regression from the switch to the KSyntaxHighlighting framework. Maybe there is a better fix? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15485 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh,

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Dominik Haumann
dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15485 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D15485: Paint code folding marker only for multiline code folding regions

2018-09-13 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Before, a XML line like ... on the same line resulted in a