This revision was automatically updated to reflect the committed changes.
Closed by commit R307:73a72d53325f: Make PersonPluginManager API public
(authored by poboiko).
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15431?vs=41640&id=41645
REVISION DETAIL
h
dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.
Nice, thank you!
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D15431
To: poboiko, #kde_pim, dvratil, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, d
poboiko marked 3 inline comments as done.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D15431
To: poboiko, #kde_pim, dvratil, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz,
vkrause, mlaurent, knauss, dvratil
poboiko updated this revision to Diff 41640.
poboiko added a comment.
Added some documentation
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15431?vs=41616&id=41640
REVISION DETAIL
https://phabricator.kde.org/D15431
AFFECTED FILES
autotests/persondat
dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.
Just some minor details and we are good to go :)
INLINE COMMENTS
> personpluginmanager.h:34
> class KPEOPLE_EXPORT PersonPluginManager
> {
Sorry, forgot to mention this in th
poboiko marked 4 inline comments as done.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D15431
To: poboiko, #kde_pim, dvratil, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, dvasin, rodsevich, winterz,
vkrause, mlaurent, knauss, dvratil
poboiko updated this revision to Diff 41616.
poboiko added a comment.
- Switched to QMutexLocker
- Changed behavior of `addDataSource` to override existing (and delete it)
- Added documentation for `addDataSource`
- Switched to KPeople logging category introduced recently
REPOSITORY
R3
dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.
Looks good, just some minor nitpicks.
-
> There some ancient compatibility code inside
PersonPluginManagerPrivate::loadDataSourcePlugins(), which was added 3 years
poboiko created this revision.
poboiko added reviewers: KDE PIM, dvratil, apol.
poboiko added a project: KDE PIM.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
This patch makes PersonPluginManager
