D15070: Bindings: Support using sys paths for python install directory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:258d6e412435: Bindings: Support using sys paths for python install directory (authored by bruns). REPOSITORY R240 Ex

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. If there are no further comments, I will push this on sunday. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

bruns added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:455 > install(DIRECTORY > ${CMAKE_BINARY_DIR}/py${pyversion}/${GPB_PYTHONNAMESPACE} > -DESTINATION > lib/python${pyversion${pyversion}_maj_min}/site-packages) > install(FILES ${sip_file

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. In D15070#347945 , @cgiboudeaux wrote: > In D15070#347944 , @bruns wrote: > > > So, after another week, no reason has been given not to accept this. > > > > 1. It fixes bro

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added a comment. In D15070#347944 , @bruns wrote: > So, after another week, no reason has been given not to accept this. > > 1. It fixes broken behavior on several platforms > 2. It does not break current setups > 3. It is cons

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. So, after another week, no reason has been given not to accept this. 1. It fixes broken behavior on several platforms 2. It does not break current setups 3. It is consistent with other config variables REPOSITORY R240 Extra CMake Modules REVISION DETAIL htt

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. In D15070#345218 , @cgiboudeaux wrote: > In D15070#344900 , @bruns wrote: > > > In D15070#344884 , @cgiboudeaux wrote: > > > > >

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added a comment. In D15070#344900 , @bruns wrote: > In D15070#344884 , @cgiboudeaux wrote: > > > In D15070#344871 , @bruns wrote: > > > > >

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. In D15070#344884 , @cgiboudeaux wrote: > In D15070#344871 , @bruns wrote: > > > As all the raised concerns have been dealed with, can we give this a try while the next KF rele

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added a comment. In D15070#344871 , @bruns wrote: > As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future? No, the empty if must be removed. Code tha

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcook

D15070: Bindings: Support using sys paths for python install directory

bruns marked 9 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

bruns updated this revision to Diff 42697. bruns marked 2 inline comments as done. bruns added a comment. Add documentation, remove leftover GPB_PYTHON${pyversion}_SITEARCH REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=42631&id=42697

D15070: Bindings: Support using sys paths for python install directory

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:39 > KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc Yes, will do. > cgiboudeaux wrote in FindPythonModuleGeneration.cmake:206-207 >

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:39 > # > > > #= KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc > FindPythonModuleGeneration.cmake:206-207

D15070: Bindings: Support using sys paths for python install directory

bruns updated this revision to Diff 42631. bruns retitled this revision from "Bindings: Query the install directory from python" to "Bindings: Support using sys paths for python install directory". bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns added