D15013: balootctl: fix 396535

bruns abandoned this revision. bruns added a comment. This has been fixed with D18829 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: bruns, jausmus Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson

D15013: balootctl: fix 396535

bruns commandeered this revision. bruns edited reviewers, added: jausmus; removed: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: bruns, jausmus Cc: bruns, mgallien, anthonyfieroni, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#314082 , @bruns wrote: > 1. Use a proper commit message, with subject and body > 2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review. Will do, my apologies. Ha

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#313885 , @mgallien wrote: > In D15013#313880 , @jausmus wrote: > > > In D15013#313867 , @anthonyfieroni wrote: > > >

D15013: balootctl: fix 396535

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. 1. Use a proper commit message, with subject and body 2. Please use "arc diff ..." to upload the diff, revisions without context are hard to review. REPOSITORY R293 Baloo REVIS

D15013: balootctl: fix 396535

mgallien added a comment. In D15013#313880 , @jausmus wrote: > In D15013#313867 , @anthonyfieroni wrote: > > > Do not use QDir::separator > > > > if (!folder.endsWith(QLatin1Char('/')) { > >

D15013: balootctl: fix 396535

jausmus added a comment. In D15013#313867 , @anthonyfieroni wrote: > Do not use QDir::separator > > if (!folder.endsWith(QLatin1Char('/')) { > folder += QLatin1Char('/'); > } > Does balooctl not need cross platform sup

D15013: balootctl: fix 396535

anthonyfieroni added a comment. Do not use QDir::separator if (!folder.endsWith(QLatin1Char('/')) { folder += QLatin1Char('/'); } REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 To: jausmus Cc: anthonyfieroni, kde-frameworks-devel, #baloo, asha

D15013: balootctl: fix 396535

jausmus created this revision. jausmus added a project: Baloo. Herald added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. jausmus requested review of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 AFFECTED FILES src/t