D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-02 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:2f9bf6673179: Android: Don't hardcode a random version of the Android SDK (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14544?vs=38

D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-02 Thread Aleix Pol Gonzalez
apol added a comment. In D14544#302017 , @alexeymin wrote: > From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine? 😄 > I mean, which o

D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14544 To: apol, #frameworks, vkrause Cc: alexeymin, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bru

D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-01 Thread Alexey Min
alexeymin added a comment. From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine? 😄 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14544 To: apol,

D14544: Android: Don't hardcode a random version of the Android SDK

2018-08-01 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, vkrause. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Just default to whiche