D14434: add functions to access keywords

dhaumann added a comment. @asemke Ok, thanks. It's available for 5.49, which is scheduled for released for Saturda 11th of August. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke Cc: vkr

D14434: add functions to access keywords

asemke added a comment. In D14434#300211 , @dhaumann wrote: > @asemke Are you sure you reference the correct Task? I cannot find anything about keyword lists in your link. @dhaumann yes, I'm sure this is the correct task. That task is abo

D14434: add functions to access keywords

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9e3f07de97ea: add functions to access keywords (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14434?vs=38629&id=38799#toc REPOSITORY R216 Syntax Highlighting CHANGES

D14434: add functions to access keywords

dhaumann added a comment. @asemke Are you sure you reference the correct Task? I cannot find anything about keyword lists in your link. Besides that, my change request with respect to API naming still stands. @jpoelen Before committing, lets have another review round, could you pleas

D14434: add functions to access keywords

asemke accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH keywordlist REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke Cc: vkrause, cullmann, asemke, kde-framew

D14434: add functions to access keywords

asemke added a comment. In D14434#299932 , @dhaumann wrote: > In general looks good to me, so +1. I would like to have another +1 from @cullmann, @vkrause or @asemke +1 > What I wonder is whether you really need the keyword lists fro

D14434: add functions to access keywords

vkrause added a comment. No objection from me, assuming you have a use-case for this (auto-completion?). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: vkrause, cullmann, asemke, kde-framew

D14434: add functions to access keywords

dhaumann added subscribers: asemke, cullmann, vkrause. dhaumann added a comment. In general looks good to me, so +1. I would like to have another +1 from @cullmann, @vkrause or @asemke What I wonder is whether you really need the keyword lists from the Definition, or whether you want the

D14434: add functions to access keywords

jpoelen added a comment. This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, kwrite-d

D14434: add functions to access keywords

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRAN