D13752: Kill solidautoeject

2018-07-03 Thread Adriaan de Groot
adridg added a comment. - Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*. - Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running. - Insert CD, pick *open in file manager* from the de

D13752: Kill solidautoeject

2018-06-27 Thread Anthony Fieroni
anthonyfieroni added a comment. I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is mounting? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson,

D13752: Kill solidautoeject

2018-06-27 Thread Kai Uwe Broulik
broulik added a comment. > It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change I think you could test it by disabling the "Drive Ejector" module in "Background Services" (kded settings) in System Settings. If pressing

D13752: Kill solidautoeject

2018-06-27 Thread Adriaan de Groot
adridg added a comment. It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D13752: Kill solidautoeject

2018-06-27 Thread Adriaan de Groot
adridg added a comment. Since the ticket is rather unclear on what functionality is being tested, or how: - Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it) - When device notifier pops up, pick "open with filemanager" (`*`) - Ensure the silesy

D13752: Kill solidautoeject

2018-06-27 Thread Marco Martin
mart added a comment. +1 (maybe build conditionally on freebsd if it's *really* necessary there) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: mart, plasma-devel, r

D13752: Kill solidautoeject

2018-06-27 Thread Fabian Vogt
fvogt added a comment. Umount on eject press still works even without the kded module loaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pit

D13752: Kill solidautoeject

2018-06-27 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D13752: Kill solidautoeject

2018-06-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, Frameworks, adridg, davidedmundson, dfaure, fvogt, ervin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Solid's