dfaure closed this revision.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
michaeleden added a dependent revision: D13988: Use subseq matching for service
runner.
REPOSITORY
R309 KService
BRANCH
feature/match-subseq
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
michaeleden added a comment.
@dfaure you can land it its no problem. I'm also not in a rush to get it into
5.48 or anything (Bug 262837 is from 2011).
I have a few diffs in review, I think I'll apply for a dev account since I'd
like to keep doing this stuff.
REPOSITORY
R309 KService
BRA
dfaure added a comment.
Ah, so you don't have a developer account, which means you can't push this
commit either, and I should do it for you?
Well, you could also apply for a developer account ;)
https://community.kde.org/Infrastructure/Get_a_Developer_Account#Apply_for_a_KDE_Developer
michaeleden added a comment.
@dfaure I don't believe I have permission to edit the wiki, can I make a
revision against it somehow?
REPOSITORY
R309 KService
BRANCH
feature/match-subseq
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-fram
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Perfect, thanks!
REPOSITORY
R309 KService
BRANCH
feature/match-subseq
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-deve
michaeleden updated this revision to Diff 37301.
michaeleden added a comment.
Respond to @dfaure comments by adding tests and separating subseq func
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13670?vs=36493&id=37301
BRANCH
feature/match-subseq
REVI
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktraderparsetree.cpp:443
> +
> + QString::Iterator i = c2.str.begin(), j = c1.str.begin();
> + for (; i != c2.str.end() && j < c1.str.end(); ++i) {
Nothing
michaeleden added a comment.
@dfaure if a user was trying to find `LibreOffice 6.0 Writer`
with `subin` they would have type `libre` to narrow it down to LibreOffice
programs, then `libreoffice 6.0 writer` to get to that application.
with `subseq` they can type `libre` to get to LibreOf
dfaure added a comment.
I'm confused, what's the difference with subin?
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
michaeleden added a reviewer: Frameworks.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D13670
To: michaeleden, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
michaeleden created this revision.
michaeleden added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
michaeleden requested review of this revision.
REVISION SUMMARY
Added `subseq` and `~subseq` operators whi
12 matches
Mail list logo
