adridg abandoned this revision.
adridg added a comment.
Yeah, let's not then.
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabricator.kde.org/D13328
To: adridg
Cc: aacid, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
adridg edited the test plan for this revision.
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabricator.kde.org/D13328
To: adridg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
aacid added a comment.
I'm with you that having a possibility to just compile kdnssd without any
backend may be of value so i would either not commit this or improve the cmake
so there's a way to say I_KNOW_WHAT_I_AM_DOING_KEEP_GOING
REPOSITORY
R272 KDNSSD
REVISION DETAIL
https://phabri
adridg updated this revision to Diff 35524.
adridg added a comment.
Use the right place (sorry Christophe, to use a Dutch phrase:
I must have been looking with my nose).
REPOSITORY
R272 KDNSSD
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13328?vs=35514&id=35524
BRANCH
requi
cgiboudeaux added inline comments.
INLINE COMMENTS
> adridg wrote in CMakeLists.txt:65-66
> Hi. If you're posting a review, please provide constructive input. If there
> are policies or guidelines about places, please link to them. If there
> aren't, but you would prefer a change, please descri
adridg added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in CMakeLists.txt:65-66
> wrong place
Hi. If you're posting a review, please provide constructive input. If there are
policies or guidelines about places, please link to them. If there aren't, but
you would prefer a change, plea
cgiboudeaux added inline comments.
INLINE COMMENTS
> CMakeLists.txt:65-66
> ecm_install_po_files_as_qm(po)
> +else()
> +message(FATAL_ERROR "Either Avahi or DNSSD is required for KDE
> applications to make use of multicast DNS/DNS-SD service discovery")
> endif()
wrong place
REPOSITO
adridg added a comment.
Something to consider, though, is that it might perhaps be useful to have
kdnssd build -- without a backend -- for environments where there is no real
dnssd and any service discovery returns "not found". Requiring a backend makes
that impossible.
(So something el
adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
adridg requested review of this revision.
REVISION SUMMARY
Refuse to build if there are no backends for DNSSD at all. The messages for
the OPTIONAL
