D13102: Don't include a 64 when building 64bit architectures on flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5cf0be9327c3: Don't include a 64 when building 64bit architectures on flatpak (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13102?v

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks, cgiboudeaux Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, mic

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a comment. Ping? @cgiboudeaux maybe you can accept the patch? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux added a comment. Thanks. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol updated this revision to Diff 35185. apol added a comment. Mention on the documentation that we don't change the lib/ value on flatpak REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13102?vs=34841&id=35185 BRANCH master REVISION DETAIL

D13102: Don't include a 64 when building 64bit architectures on flatpak

eszlari added a comment. In D13102#268116 , @apol wrote: > I don't really see how to put it without reading convoluted. Also as is, the documentation isn't wrong, we are just changing the logic to use one or another. Maybe he just wants

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a comment. In D13102#268015 , @cgiboudeaux wrote: > Please update the doc above. the documentation right now is: # ``LIBDIR`` # object code libraries (``EXECROOTDIR/lib``, ``EXECROOTDIR/lib64`` or # ``EXE

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux added a comment. Please update the doc above. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a subscriber: eszlari. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's not a thing on flatpak an