D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham updated this revision to Diff 35890. ngraham added a comment. Also make this change for all other toolButtons that open menus REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13026?vs=34604&id=35890 BRANCH schema-toolbar-button-opens-on-normal-c

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham planned changes to this revision. ngraham added a comment. I don't think being `delayed` was a deliberate choice; it's simply the default interaction method for toolbuttons that open menus in Qt (for some odd reason). Every menu toolbutton throughout KDE software that shows its menu

D13026: Open Schema toolbar button with normal click rather than click-and-hold

dhaumann added a comment. The same holds true for other actions such as: Tools > Highlighting, Mode, Indentation, Script. Question here is: Is this delayed thing needed for building the contents on-the-fly (look at the aboutToShow() functions)? REPOSITORY R39 KTextEditor REVISION DET

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann,

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added reviewers: dhaumann, cullmann. ngraham added a comment. Friendly ping! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate, dhaumann, cullmann Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevin

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added a comment. Fair enough! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

hpereiradacosta added a comment. Hello, I would appreciate that you rephrase the description for this patch (and others where the same comment appear): the dissapearing arrow with breeze is not a *bug* in breeze, but a (conscious) design choice, that is discussed in D13064

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added a comment. Friendly ping! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham created this revision. ngraham added reviewers: KTextEditor, Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. ngraham requested review of this revision. REVISION SUMMARY Fixes Kate/KWrite's Schema