D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R284:fbb5609001ab: Fix KCompletionBox on wayland (authored by apol). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12448?vs=32805&id=32833 REVISION DETAIL https:

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
apol added a comment. In D12448#251908 , @anthonyfieroni wrote: > Why not > > static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerH

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Anthony Fieroni
anthonyfieroni added a comment. Why not static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's a bit cheeky, but it's the only soltuion that doesn't require an invasive patch inverting the way input is eventFiltered. REPOSITORY R284 KCompletion BRANCH master

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY On wayland it would immediately disappear, now it doesn't anymore. TEST PLAN Tried kcompletionuitest on xc