D12251: Integrate with androiddeployqt dependencies files

apol abandoned this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

aacid added a comment. threre's not so many unneded stuff in there to be honest, maybe kross, kate and the emoticonthemes, but doesn't seem terrible. One would improve that by not depending on the whole kf5umbrella probably? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde

D12251: Integrate with androiddeployqt dependencies files

apol added a comment. I don't really see why we need a special path for parts. > I understand you're doing it to be able to just get everything from that folder and then put it on the apk > > Now without knowing anything about cmake, wouldn't it make more sense put on the apk every

D12251: Integrate with androiddeployqt dependencies files

aacid added inline comments. INLINE COMMENTS > part.h:69 > + * This KPart will be exported as a plugin. It requires a desktop file that > + * needs to be installed to be installed to ${KDE_INSTALL_KSERVICES5DIR} with > + * its exposed interfaces (e.g. > X-KDE-ServiceTypes=KParts/ReadOnlyPart,KPa

D12251: Integrate with androiddeployqt dependencies files

apol updated this revision to Diff 32462. apol added a comment. Don't generate the xml file in the sources dir REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12251?vs=32313&id=32462 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 AFFE

D12251: Integrate with androiddeployqt dependencies files

apol added a comment. Related and reason of albert's comment: https://phabricator.kde.org/D12250 REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

apol updated this revision to Diff 32313. apol added a comment. Document installation process REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12251?vs=32301&id=32313 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 AFFECTED FILES src/

D12251: Integrate with androiddeployqt dependencies files

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

aacid added a comment. I'm not convinced at all parts are not in that folder. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D12251 To: apol, #frameworks, vkrause, aacid Cc: michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

apol created this revision. apol added reviewers: Frameworks, vkrause, aacid. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Tell androiddeployqt where to look instead of just installing everything TEST PLAN okularpart gets in okul