kossebau abandoned this revision.
kossebau added a comment.
Sadly lost track of things, and no plans to look soon again at it, so
cleaning up from stack for now.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D12164
To: kossebau, ilic
Cc: aacid, kde-framewor
aacid added a comment.
The docu of ki18n says we localize numbers (as far as i remember), so that
patch you discarded is "the right thing" imho
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D12164
To: kossebau, ilic
Cc: aacid, kde-frameworks-devel, huftis,
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D12164
To: kossebau, ilic
Cc: kde-frameworks-devel, huftis, broulik, michaelh, ngraham, bruns, #frameworks
kossebau added a comment.
As discussed on irc with @broulik will give that other patch
https://git.reviewboard.kde.org/r/127800/ some look again, as I would agree
numbers rather should be localized there.
Had considered something like that before as well, but then discarded due to
not s
broulik added a comment.
+1 always annoyed me that the converter runner didn't use localed decimal
points
See also https://git.reviewboard.kde.org/r/127800/
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D12164
To: kossebau, ilic
Cc: broulik, #framework
kossebau created this revision.
kossebau added a reviewer: ilic.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.
REVISION SUMMARY
The existing toString/toSymbolString methods use KLocalizedStri
