D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246895 , @bcooksley wrote: > If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed Good to know, thanks. REPOSITORY R293 Baloo REVISI

D12135: Allow disabling of CoW to fail when not supported by filesystem

bcooksley added a comment. If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: bcooksley, adrid

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. In D12135#246831 , @bcooksley wrote: > The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff. Yes, thanks. That's th

D12135: Allow disabling of CoW to fail when not supported by filesystem

This revision was automatically updated to reflect the committed changes. Closed by commit R293:92ff146f5563: Allow disabling of CoW to fail when not supported by filesystem (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12135?vs=32074&id=32211#toc REPOSITORY R293

D12135: Allow disabling of CoW to fail when not supported by filesystem

bcooksley added a comment. The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, a

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh accepted this revision. michaelh added a comment. This revision is now accepted and ready to land. Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known REPOSITORY R293 Baloo BRANCH master REVISION DETAIL ht

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a comment. @michaelh can you accept - I can't ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexey

D12135: Allow disabling of CoW to fail when not supported by filesystem

michaelh added a comment. +1 LGTM REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns updated this revision to Diff 32074. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12135?vs=31946&id=32074 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12135 AFFECTED FILES src/engine/fsutils.cpp s

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns requested review of this revision. bruns added a comment. Make it obvious this should have some more review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a comment. May I have another accept/review (for the stack) from #Frameworks or #Baloo ? REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Accepted as "doesn't hurt the non-Linux crowd, since they all live in the #ifndef Q_OS_LINUX branch" REPOSITORY R293 Baloo BRANCH accept_eopnotsupp_on_chattr REVISION DETAIL https:/

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns updated this revision to Diff 31946. bruns edited the test plan for this revision. bruns added a comment. update function documentation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12135?vs=31943&id=31946 BRANCH accept_eopnotsupp_on_chattr REVISIO

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a dependent revision: D12136: Avoid hardcoding of filesystems supporting CoW. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns created this revision. bruns added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY It is fine to neither support reading of attrs nor setting the NO