D11346: Only set iconText() if actually changed

This revision was automatically updated to reflect the committed changes. Closed by commit R236:7fe64f532d38: [KAcceleratorManager] Only set iconText() if actually changed (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11346?vs=2955

D11346: Only set iconText() if actually changed

cfeck added inline comments. INLINE COMMENTS > apol wrote in kacceleratormanager.cpp:792 > What happens when iconText.isEmpty()? Qt returns QAction::text() when QAction::iconText() is empty. Apparently Qt also strips some text, so to check if there was no iconText(), we need this weird check i

D11346: Only set iconText() if actually changed

apol added inline comments. INLINE COMMENTS > kacceleratormanager.cpp:792 > // Check if iconText was generated by Qt. In that case ignore it (no > support for CJK accelerators) and set it from the text. > if (iconText == copy_of_qt_strippedText(oldText)) { > iconTe

D11346: Only set iconText() if actually changed

chehrlic accepted this revision. chehrlic added a comment. This revision is now accepted and ready to land. This should at least fix the most cases as described in the bug report :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11346 To: cfeck, #frameworks,

D11346: Only set iconText() if actually changed

cfeck created this revision. cfeck added a reviewer: Frameworks. Restricted Application added a project: Frameworks. cfeck requested review of this revision. REVISION SUMMARY QAction::setIconText() breaks the feature that QAction::iconText() is returning text() when the iconText is empty.