D11156: add autotest for zips within zips

sandsmark abandoned this revision. sandsmark added a comment. I landed it manually, I hope that's okay: https://cgit.kde.org/karchive.git/commit/?id=17d409236a792fb0db93ab6109fd30b2d51ccc1a I also noticed that a couple of the other tests failed here, seems like there's some assumptions o

D11156: add autotest for zips within zips

dfaure added a comment. The command you're looking for is `arc patch D11156` (tested, works) REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11156 To: sandsmark, dfaure, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D11156: add autotest for zips within zips

sandsmark added a comment. In D11156#501817 , @dfaure wrote: > @sandsmark can you add an expected list of files like other tests do? Yeah, I just need to find out which machine I wrote this on because it is hard to download patches with b

D11156: add autotest for zips within zips

dfaure added a comment. Herald added a subscriber: kde-frameworks-devel. @sandsmark can you add an expected list of files like other tests do? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11156 To: sandsmark, dfaure, #frameworks Cc: kde-frameworks-devel, #framewo

D11156: add autotest for zips within zips

dfaure added inline comments. INLINE COMMENTS > karchivetest.cpp:1156 > + > +QVERIFY(zip.open(QIODevice::ReadOnly)); > +} A check for a file listing would avoid that just "return true" in open() is enough for the test to pass :-) REPOSITORY R243 KArchive REVISION DETAIL https://phabri

D11156: add autotest for zips within zips

sandsmark created this revision. sandsmark added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY an epub in a zip file compressed by e. g. the golang standard zip library, or infozip in streaming mo