D11155: handle zip files embedded within zip files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:07e5678981c6: handle zip files embedded within zip files (authored by sandsmark, committed by aacid). Restricted Application added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT https://

D11155: handle zip files embedded within zip files

dfaure accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

sandsmark added a comment. In D11155#250677 , @ngraham wrote: > Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821? I believe so REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraha

D11155: handle zip files embedded within zip files

sandsmark updated this revision to Diff 33747. sandsmark marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11155?vs=29011&id=33747 REVISION DETAIL https://phabricator.kde.org/D11155 AFFECTED FILES kzip.cpp To: sandsmark, dfaure, #frameworks Cc: ngrah

D11155: handle zip files embedded within zip files

ngraham added a comment. Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

dfaure added a comment. ping? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: #frameworks, michaelh, bruns

D11155: handle zip files embedded within zip files

dfaure added inline comments. INLINE COMMENTS > kzip.cpp:347 > * @param dev device that is read from > * @return true if a local or central header token could be reached, false > on error can you document the new boolean param as well? REPOSITORY R243 KArchive REVISION DETAIL https://

D11155: handle zip files embedded within zip files

sandsmark created this revision. sandsmark added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY if we need to fetch the sizes from a PK78 header, there might be a PK34 header before it if there is