D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

bruns added a comment. In D10657#446950 , @broulik wrote: > Superseded by D10657 Superseded by itself? D19677 ? REPOSITORY R245 Solid REVISION DETAIL https://ph

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik abandoned this revision. broulik added a comment. Herald added a subscriber: kde-frameworks-devel. Superseded by D10657 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc:

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik planned changes to this revision. broulik added a comment. Good idea REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc: ngraham, michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

davidedmundson added a comment. IMHO if we're fixing it, I'd go all-in and port from introspect to GetManagedObjects on the object manager. You get rid of all XML parsing and you'd get the initial properties in the same call (instead of an additional one per iface) You could even do al

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

ngraham added a comment. These kinds of changes to Solid are going to need some *ahem* solid testing (I just kill myself sometimes) to avoid regressions, like the one we had in https://bugs.kde.org/show_bug.cgi?id=389479 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc: michaelh

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY The Qt Xml module is not actively maintained anymore and docs suggest to use QXmlStreamReader. Th