This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8b34864135f8: Remove handling of privilege operation
confirmation prompts from KIO::Job (authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10567?vs=
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
D10567
REVISION DETAIL
https://phabricator.kde.org/D10567
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh
chinmoyr updated this revision to Diff 28539.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.
fix issue with variable declaration
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10567?vs=27478&id=28539
BRANCH
D10567
REVISION DETAIL
htt
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> job.cpp:269
>
> +QByteArray jobData;
> if (m_parentJob) {
This feels like C code ;)
> job.cpp:271
> if (m_parentJob) {
> -if (!m_pare
chinmoyr added a dependent revision: D10568: Handle privilege operation
confirmation prompts in SlaveBase.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10567
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh
chinmoyr updated this revision to Diff 27478.
chinmoyr added a comment.
removed m_data
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10567?vs=27315&id=27478
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10567
AFFECTED FILES
src/core/job.c
dfaure added inline comments.
INLINE COMMENTS
> job.cpp:328
>
> -switch (m_operationType) {
> -case ChangeAttr:
> -m_caption = i18n("Change Attribute");
> -m_message = i18n("Root privileges are required to change file
> attributes. "
> - "Do you
chinmoyr edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10567
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh
chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.
REVISION SUMMARY
Letting KIO::Job handle these prompts is pointless because an
