D18915: Fix batchrename changing extension to lower case

cfoster added a comment. What needs to happen now for this to be accepted? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 54269. cfoster added a comment. - Add unit tests. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=53914&id=54269 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde.org/D18915 AFFECTED F

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 53914. cfoster added a comment. - Pass QString by reference REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=53068&id=53914 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde.org/D18915 AFFE

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 53068. cfoster added a comment. - Change GetFileExtension to take QString REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=52691&id=53068 BRANCH arcpatch-D18915 REVISION DETAIL https://phabricator.kde

D18915: Fix batchrename changing extension to lower case

cfoster marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

cfoster added inline comments. INLINE COMMENTS > bruns wrote in batchrenamejob.cpp:165 > I think you can use `QUrl::filename()`, and you should do it from the calling > code. Just making sure I understand you correctly. Are you saying I should change the function to take the file

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 52691. cfoster added a comment. - Add function for getting extension All unit tests pass Manually tested invalid extensions. Files with no extensions and files with upper and lower case extensions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18915: Fix batchrename changing extension to lower case

cfoster added a comment. In D18915#416400 <https://phabricator.kde.org/D18915#416400>, @bruns wrote: > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName > > > Returns the suffix for the file fileName, as known by the MIME database. > > This allow

D18915: Fix batchrename changing extension to lower case

cfoster added inline comments. INLINE COMMENTS > ngraham wrote in batchrenamejob.cpp:181 > Is it? > > `file.tar.gz` Ah yes... very good point... I think have to rethink how to solve this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfost

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 52180. cfoster added a comment. - Changes after review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18915?vs=51372&id=52180 BRANCH arcpatch-D18915_2 REVISION DETAIL https://phabricator.kde.org/D1

D18915: Fix batchrename changing extension to lower case

cfoster added inline comments. INLINE COMMENTS > abalaji wrote in batchrenamejob.cpp:62 > You can just `QString dot = "."`, but you should use a single character > instead of a string, since it's just a single character Without the fromStdString() I get the following

D18915: Fix batchrename changing extension to lower case

cfoster created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfoster requested review of this revision. REVISION SUMMARY Files renamed with Dolphins batch rename would have their file extensions always converted to lower case. New