D13698: Improve ECMAddAppIconMacro.

2018-06-24 Thread Vincent Pinon
vpinon added inline comments. INLINE COMMENTS > dschmidt wrote in FindIcoTool.cmake:1 > @vpinon Can you let me know what you want here? Hello, FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure I can really claim the copyright. In any case, I would choose the same lic

D8427: Allow cross compiling resource file

2017-10-24 Thread Vincent Pinon
vpinon added a comment. Note: if you want to see the rest of frameworks cross-building for Kdenlive: https://github.com/vpinon/mxe/tree/master/plugins/kdeframeworks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, b

D8427: Allow cross compiling resource file

2017-10-24 Thread Vincent Pinon
vpinon added a comment. Thank you Aleix, You're right! //Before// launching cmake for cross compiling, I build the tool for host (this requires to have Qt5 dev files on build host): I haven't found a way to access the host compiler & libs //within// cmake (which has a toolchain file to

D8428: Fix cross-compiling with MinGW (MXE)

2017-10-22 Thread Vincent Pinon
vpinon created this revision. vpinon added reviewers: vonreth, habacker. vpinon added a project: Kdenlive. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY While cross-compiling Kdenlive with MXE (mingw64), I don't get pi

D8427: Allow cross compiling resource file

2017-10-22 Thread Vincent Pinon
vpinon created this revision. vpinon added reviewers: apol, kfunk. vpinon added a project: Kdenlive. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY While cross-compiling Kdenlive with MXE, I had to use host's qrcAlias.

D8281: Allow to use IcoTool for Windows icons

2017-10-13 Thread Vincent Pinon
vpinon created this revision. vpinon added reviewers: dfaure, apol, kfunk. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY ECM to creating application icons asks for png2ico on Windows target.