D18664: Baloo engine: treat every non-success code as a failure

This revision was automatically updated to reflect the committed changes. Closed by commit R293:eb68430ae5f4: Baloo engine: treat every non-success code as a failure (authored by valeriymalov). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18664?vs=53608&id=53838#toc REPOSITORY R293 B

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 53608. valeriymalov marked 3 inline comments as done. valeriymalov added a comment. - do not ignore results of PostingDB::iter in case of an error/end of db REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=522

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 52229. valeriymalov added a comment. - fix MTimeDB::get loop REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=52216&id=52229 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18664 AFFECTED FIL

D18873: add baloo engine debugging category

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f5f1ae889fe9: add baloo engine debugging category (authored by valeriymalov). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51279&id=52220 REVISION DETAIL

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 52216. valeriymalov marked 4 inline comments as done. valeriymalov added a comment. - review warning fixes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=51284&id=52216 BRANCH master REVISION DETAIL ht

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51284. valeriymalov marked 4 inline comments as done. valeriymalov added a comment. - fix ::del error logging criteria, don't return without closing cursor in REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=5

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added inline comments. INLINE COMMENTS > bruns wrote in documentdatadb.cpp:107 > see get Trying to delete a non-existent entry seems like an error to me REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullm

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51282. valeriymalov marked 10 inline comments as done. valeriymalov added a comment. - update logging per review REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=51252&id=51282 BRANCH master REVISION DETAI

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51279. valeriymalov added a comment. is it now how it's supposed to look in the end? not really sure where .category syntax is defined REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51261&id=51279 BRANCH

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51261. valeriymalov added a comment. - update categories per review REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51255&id=51261 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 AFFEC

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added a dependency: D18873: add baloo engine debugging category. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spo

D18873: add baloo engine debugging category

valeriymalov added a dependent revision: D18664: Baloo engine: treat every non-success code as a failure. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh,

D18873: add baloo engine debugging category

valeriymalov marked an inline comment as done. valeriymalov added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:31 > which files uses it ? > you generate it but it seems that you don't use it in file no ? I've been asked to split this from D18664: Baloo engine: treat every

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51255. valeriymalov added a comment. - use new syntax for baloo.categories REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51248&id=51255 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51252. valeriymalov added a comment. - move new logging category to D18873: add baloo engine debugging category REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=51251&id=5

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 51251. valeriymalov marked 3 inline comments as done. valeriymalov added a comment. - clean up rest of the asserts REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=50708&id=51251 BRANCH master REVISION DET

D18873: add baloo engine debugging category

valeriymalov created this revision. valeriymalov added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.o

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov planned changes to this revision. valeriymalov added a comment. In D18664#404173 , @poboiko wrote: > 1. Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead of BUG inside the commit

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 50708. valeriymalov added a comment. - unbreak documentdatadb::contains, oops :( REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=50706&id=50708 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY Treating only MDB_NOTFOUND as an error leads to use of uninitliazed pointers and handle IDs in o

D15406: Manually resize KCMUtilDialog to sizeHint()

This revision was automatically updated to reflect the committed changes. Closed by commit R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() (authored by valeriymalov). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15406?vs=41344&id=41446 REVIS

D15406: Manually resize KCMUtilDialog to sizeHint()

valeriymalov added a comment. neither `QWidget::adjustSize()` nor `QWidget::adjustedSize()` seem to use `devicePixelRatio` (https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665), but I can't test that to vouch that it works on HiDPI as intended I can land it as i

D15406: Manually resize KCMUtilDialog to sizeHint()

valeriymalov created this revision. valeriymalov added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY Workaround for https://bugreports.qt.io/browse/QTBUG-3459

D14692: Use custom QScrollArea with size hint not limited by font size

This revision was automatically updated to reflect the committed changes. Closed by commit R295:23ba2b37ef82: Use custom QScrollArea with size hint not limited by font size (authored by valeriymalov). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14692?vs=39

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a comment. I don't know, it's frameworks after all but I guess I can land it today since it's a popular bug. Should I just land it on master since there seem to be no other branches? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov updated this revision to Diff 39313. valeriymalov added a comment. - add link to qt bug REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14692?vs=39308&id=39313 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 AFFECTED FIL

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a comment. I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bru

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov added a reviewer: Frameworks. valeriymalov added a comment. Context for the size hint limitation this patch is supposed to circumvent: https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.

D14692: Use custom QScrollArea with size hint not limited by font size

valeriymalov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REVISION SUMMARY For some reason original QScrollArea has constraint on a size hint This caus

D11628: Fix remotedirnotify service file

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6338394f3424: Fix remotedirnotify service file (authored by valeriymalov). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11628?vs=30358&id=30443 REVISION DETAIL htt

D11628: Fix remotedirnotify service file

valeriymalov created this revision. valeriymalov added a reviewer: Frameworks. Restricted Application added a project: Frameworks. valeriymalov requested review of this revision. REVISION SUMMARY kded plugin is actually named "remotenotifier", update .desktop file accordingly This should fix

D7487: Make KCMultiDialog scrollable

valeriymalov added a comment. In https://phabricator.kde.org/D7487#141996, @davidedmundson wrote: > For some reason "kcmshell5 kscreen" looks awful. It comes up tiny. This seems to be caused by the way KScreen's KCM is initialized, probably because of QML? Window content seems to

D7487: Make KCMultiDialog scrollable

valeriymalov updated this revision to Diff 18774. valeriymalov edited the summary of this revision. valeriymalov added a comment. Oops, should be fixed now REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18616&id=18774 BRANCH master REVISION DET

D7487: Make KCMultiDialog scrollable

valeriymalov updated this revision to Diff 18616. valeriymalov added a comment. Split commit in two (hopefully) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18604&id=18616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFF

D7487: Make KCMultiDialog scrollable

valeriymalov created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Put KCModuleProxy into a QScrollArea the same way SystemSettings does This should make kcmshell and other users of KCMultiDialog a bit more friendly to small screens However, this as

D6277: Emit errors when keditbookmarks is missing

valeriymalov updated this revision to Diff 15681. valeriymalov added a comment. Toned down error from critical to warning, removed const cast REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6277?vs=15608&id=15681 REVISION DETAIL https://phabricator.kde

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked 2 inline comments as done. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked an inline comment as done. valeriymalov added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:341 > Why const_cast? Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it doesn't change the object, yet we need to emit non-const

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked 2 inline comments as done. valeriymalov added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:335 > Have you checked errorString actually returns something? > > Given startDetached is static it seems kind of weird it would update the > "this" errorStri

D6277: Emit errors when keditbookmarks is missing

valeriymalov updated this revision to Diff 15608. valeriymalov added a comment. Call startDetached without an object since it's static (my bad, QProcess object does return an error but it's UnknownError and I assume should be seeing FailedToStart; there doesn't seem to be any other interestin

D6277: Emit errors when keditbookmarks is missing

valeriymalov edited the summary of this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks Cc: ltoscano

D6277: Emit errors when keditbookmarks is missing

valeriymalov created this revision. valeriymalov added a project: Frameworks. REVISION SUMMARY KBookmarkManager::slotEditBookmarks is supposed to run keditbookmarks, but does not emit any errors when if it's missing This makes "Edit bookmarks" menu fail silently in applications that use KBoo