D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. In D18739#407649 , @broulik wrote: > If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. > > kcmshell5 icons style > > > Switch between the t

D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. As mentioned in D18458 , a KCM not based on KCM.GridViewKCM & friends (e.g. a KCM based on Kirigami.Page) will now get extra padding (on Breeze, no scaling, it's of 6px), both on KCMShell and SystemSettings. REPOSITORY R295 KCMUti

D4799: Delay notifications until desktop session has loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2d40672b0c85: Do not remove queued notifications when the fd.o service starts. Also start the… (authored by vpilo). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde

D4799: Delay notifications until desktop session has loaded

vpilo added a comment. Ping [my excuses if it's not good practice to do so] REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson,

D4799: Delay notifications until desktop session has loaded

vpilo added a comment. I pushed https://phabricator.kde.org/D5012; this rev is now testable. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davi

D4799: Delay notifications until desktop session has loaded

vpilo added reviewers: davidedmundson, dfaure, broulik, graesslin, mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson, dfaure, br

D4799: Delay notifications until desktop session has loaded

vpilo updated this revision to Diff 12377. vpilo marked an inline comment as done. vpilo added reviewers: Plasma, Plasma: Workspaces. vpilo added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. New patchset. I moved the waiti

D4799: Delay notifications until desktop session has loaded

vpilo added a dependent revision: D5012: Delay notifications until desktop session has loaded. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo Cc: davidedmundson, dfaure, broulik, graesslin, mck182, #frameworks

D4799: Delay notifications until desktop session has loaded

vpilo updated this revision to Diff 12310. vpilo added a comment. New version, using the idea suggested by @davidedmundson . The KNotifications manager was clearing queued notifications also when the fd.o Notifications service initially registers; and while I get that it's done on unregi

D4799: Delay notifications until desktop session has loaded

vpilo added a comment. View Revision In D4799#91246, @davidedmundson wrote: There is another solution that would work without any changes to KNotification. DBus has a solution to buffer messages and wait for a name to become available, it happens in DBus activation. If plasmashell was DBus activat

[Differential] [Closed] D4801: KNotifications cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R289:76ca9bc01c6f: Removed some dead code. (authored by vpilo). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4801?vs=11835&id=12031 REVISION DETAIL https://ph

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

vpilo added a comment. In https://phabricator.kde.org/D4799#91109, @dfaure wrote: > Yes interface->isServiceRegistered(dbusServiceName) is technically blocking, but it can't block for a long time, since it's only talking to the dbus daemon. The reply comes in rather quickly, unlike a blo

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

vpilo added a comment. @mck182 I didn't notice before, but KNotifications is already making blocking calls on creation: src/notifybypopup.cpp@182: QDBusConnectionInterface *interface = QDBusConnection::sessionBus().interface(); d->dbusServiceExists = interface && inter

[Differential] [Updated] D4801: KNotifications cleanup

vpilo edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4801 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vpilo Cc: #frameworks

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

vpilo added a comment. In https://phabricator.kde.org/D4799#90169, @dfaure wrote: > About the code in kded that calls ksplash: that code is obsolete and currently only kept for compatibility reasons, see https://git.reviewboard.kde.org/r/129010/ > IOW you can ignore that code complete

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

vpilo added a comment. @graesslin I disagree. Some popups might be useful, some are very useful; we should aim to never drop any. Just as an example, the popup with the Yakuake console toggle key is pretty fundamental to be reminded of, the first few times you start it up. It's all abou

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

vpilo added a comment. In https://phabricator.kde.org/D4799#89931, @mck182 wrote: > Thanks for the patch! I wanted to do exactly this a long > time ago. However this solution brings a burden to all > apps using KNotification in form of a blocking dbus call > which is further only

[Differential] [Request, 16 lines] D4801: KNotifications cleanup

vpilo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Removed some dead code REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4801 AFFECTED FILES src/knotificati

[Differential] [Request, 35 lines] D4799: Delay notifications until desktop session has loaded

vpilo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The KNotifications library is immediately available for programs to send out notifications from the beginning of a desktop session. But if a s