D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-31 Thread Tim __
kadabash added a comment. While adapting the settings window in Cantor to this proposed change I have discovered that it influences the `sizeHint()` of other (non-modified) pages in the same window. This leads to a worse layout than before. As I cannot currently find the source of that b

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-19 Thread Tim __
kadabash updated this revision to Diff 43944. kadabash added a comment. Fit page content horizontally *and* vertically Vertical fitting only occurs on displays that Qt deems large enough. Displays that are just high enough to fit the content vertically are apparently sometimes not con

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Tim __
kadabash added a comment. In D16137#342973 , @aacid wrote: > That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone nee

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Tim __
kadabash updated this revision to Diff 43607. kadabash added a comment. Generalize page flags to options not related to alignment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43499&id=43607 BRANCH config-dialog-content-fit (branched fro

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-12 Thread Tim __
kadabash added a comment. Sorry for the duplicate updates, I messed up my Arcanist commands. Thanks for your help so far, I tried to follow your suggestions in the above change. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To: kadabash Cc: aacid

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-12 Thread Tim __
kadabash updated this revision to Diff 43499. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43498&id=43499 BRANCH config-dialog-content-fit (branched fr

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-12 Thread Tim __
kadabash updated this revision to Diff 43498. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43413&id=43498 BRANCH config-dialog-content-fit (branched fr

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-12 Thread Tim __
kadabash added a comment. I have to admit, I don't know how to implement a version with flags correctly. Did I understand you correctly in that an overload with signature addPage(QWidget *page, const QString &itemName, const QString &pixmapName = QString(), const QString &header =

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-11 Thread Tim __
kadabash created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kadabash requested review of this revision. REVISION SUMMARY Scrolling a settings page horizontally feels awkward most of the time. This (optionally) lets the dialogue resize wh