D24641: Collect more information from version control systems

2019-12-09 Thread Thomas Fischer
thomasfischer updated this revision to Diff 71145. thomasfischer marked 4 inline comments as done. thomasfischer edited the summary of this revision. thomasfischer edited the test plan for this revision. thomasfischer added a comment. I tried to address the most recent comments: - Added do

D24641: Collect more information from version control systems

2019-11-03 Thread Thomas Fischer
thomasfischer updated this revision to Diff 69225. thomasfischer added a comment. I updated the diff. I was quite surprised about the time it takes to compute the number of commits (26 seconds), thus I removed this functionality completely. As of now, only 'revision' and 'branch' are queried

D24641: Collect more information from version control systems

2019-11-03 Thread Thomas Fischer
thomasfischer edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

2019-10-16 Thread Thomas Fischer
thomasfischer updated this revision to Diff 68072. thomasfischer added a comment. I rewrote the patch to address the comments: 1. Setting `ECM_SOURCE_UNDER_VERSION_CONTROL` has been refactored to set variable `ECM_SOURCE_VERSION_CONTROL_WHICH` as well to determine which of three known VC

D24641: Collect more information from version control systems

2019-10-14 Thread Thomas Fischer
thomasfischer edited the summary of this revision. thomasfischer added reviewers: sitter, kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy

D24641: Collect more information from version control systems

2019-10-14 Thread Thomas Fischer
thomasfischer created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. thomasfischer requested review of this revision. REVISION SUMMARY In KBibTeX, there is a `getgit.cmake`

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

2019-02-25 Thread Thomas Fischer
This revision was automatically updated to reflect the committed changes. Closed by commit R237:3bfe329b7136: KConfig: Assign documentation to correct enum value (authored by thomasfischer). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19320?vs=52558&id=5256

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

2019-02-25 Thread Thomas Fischer
thomasfischer added reviewers: broulik, dfaure, davidedmundson. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19320 To: thomasfischer, broulik, dfaure, davidedmundson Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

2019-02-25 Thread Thomas Fischer
thomasfischer created this revision. thomasfischer added a project: Documentation. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thomasfischer requested review of this revision. REVISION SUMMARY In commit 8579ec54