D18450: Add extractor for AppImage files

2019-01-29 Thread TheAssassin
TheAssassin added a comment. You can use a system Google test installation by setting `-DUSE_SYSTEM_GTEST=ON`, IIRC. But it's easier to simply `git submodule --init --recursive`. `LIBAPPIMAGE_BINARIES` doesn't exist, maybe it existed for a short while but got deleted. @kosseb

D18450: Add extractor for AppImage files

2019-01-27 Thread TheAssassin
TheAssassin added a comment. In D18450#400865 <https://phabricator.kde.org/D18450#400865>, @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread TheAssassin
TheAssassin added a comment. Yep, it's really nice, thanks @kossebau! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

2018-11-27 Thread TheAssassin
TheAssassin accepted this revision. REPOSITORY R266 Breeze Icons BRANCH addappimageiconv2 REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham, TheAssassin Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment. Quoting myself: > You might also add a 1 somewhere in there to indicate the type, but as both are still relevant and should mostly work equally, that's not really necessary. I think more and more that there shouldn't be different ic

D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment. AFAIK `vnd.appimage` resolves to type 2, whereas `x-[iso9660-]appimage` resolves to type 1. At least that's the MIME data I've been working with all the time so far. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/

D17086: Add icons for application-vnd.appimage

2018-11-25 Thread TheAssassin
TheAssassin added a comment. The new logos look great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17086 To: kossebau, #vdg, ngraham Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

2018-11-22 Thread TheAssassin
TheAssassin added a comment. There will be packages for libappimage (hopefully) soon, which provide a `.pc` file. This provides an alternative to using these generated CMake config files, which can be used through CMake's pkg-config module (`find_package(PkgConfig)`). REPOSITORY R32

D17086: Add icons for application-vnd.appimage

2018-11-22 Thread TheAssassin
TheAssassin added a comment. AppImages are, after all, only ELF executables. They're not archives. Using a zipper implies this, though. I really like the initial version that mimics the "normal executable" icon better. The dark blue is quite nice, but I thought perhaps a

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-17 Thread TheAssassin
TheAssassin added a comment. The AppImage project doesn't do any versioning right now. We've recently extracted libappimage into a separate project to be able to start versioning of it, as projects like KDE expect and somehow need that. We're discussing a suitable versioni

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-09-11 Thread TheAssassin
TheAssassin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15417 To: broulik, #frameworks, TheAssassin, anthonyfieroni