D5983: Check error status after every PolKitAuthority usage

skalinichev added a comment. In https://phabricator.kde.org/D5983#114146, @aacid wrote: > I find this impolite, it was on my queue for reviewing properly, just i have had a very busy week. Ah, sorry for the misunderstanding, I simply thought that you didn't care about it anymore

D5983: Check error status after every PolKitAuthority usage

skalinichev added a comment. In https://phabricator.kde.org/D5983#113975, @aacid wrote: > Did you commit this on purpose without the review being accepted or was it a mistake? Yeah, I did it on purpose since: 1. It was on review long enough (more than a week), so anyone who w

D5983: Check error status after every PolKitAuthority usage

This revision was automatically updated to reflect the committed changes. Closed by commit R283:ada2dc24381b: Check error status after every PolKitAuthority usage (authored by skalinichev). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5983?vs=14908&id=15127 R

D5983: Check error status after every PolKitAuthority usage

skalinichev added a comment. In https://phabricator.kde.org/D5983#112386, @aacid wrote: > Have you had these errors happen to you? > > How can one reproduce them? > > Or is it more of a "this should be the right code but i don't know how to trigger it" case? Yes, for me it

D5983: Check error status after every PolKitAuthority usage

skalinichev added inline comments. INLINE COMMENTS > aacid wrote in Polkit1Backend.cpp:220 > This seems a bit weird since we have done nothing with authority here, so how > would it have an error? Thinking a bit more about it, it can actually happen if enumerateActions call failed. REPOSITORY

D5983: Check error status after every PolKitAuthority usage

skalinichev updated this revision to Diff 14908. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5983?vs=14871&id=14908 REVISION DETAIL https://phabricator.kde.org/D5983 AFFECTED FILES src/backends/polkit-1/Polkit1Backend.cpp To: skalinichev Cc: aacid, #fra

D5983: Check error status after every PolKitAuthority usage

skalinichev added inline comments. INLINE COMMENTS > aacid wrote in Polkit1Backend.cpp:220 > This seems a bit weird since we have done nothing with authority here, so how > would it have an error? Well yes it shouldn't happen now with the two other checks above. This check here just in case (t

D5983: Check error status after every PolKitAuthority usage

skalinichev created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise if some error occurred in e.g. checkAuthorizationSync call, enumerateActions call would also fail (as PolKitAuthority already set error flag internally) REPOSITORY R283 KAuth R

D5023: Restore Cancel button shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8ea3b3403dba: Restore Cancel button shortcut (authored by skalinichev). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5023?vs=12402&id=12407 REVISION DETAIL https:/

D5023: Restore Cancel button shortcut

skalinichev created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY "Ok" and "Cancel" buttons are commonly used with alt+o and alt+c shortcuts. But currently alt+c shortcut is assigned to the Checksums tab, which is very confusing especially when Checksums p

Re: Review Request 129855: Treat no passphrase as Solid::UserCanceled error

marked as submitted. Review request for KDE Frameworks and Solid. Changes --- Submitted with commit 49367aeb366b3e695f920ff0881bc61bce92066b by Albert Astals Cid on behalf of Sergey Kalinichev to branch master. Repository: solid Description --- This should help to distinguish &qu

Review Request 129855: Treat no passphrase as Solid::UserCanceled error

9855/diff/ Testing --- Thanks, Sergey Kalinichev