rrosch added a comment.
Tested, no crashes, it works as intended, and it is beautiful! Thank you!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25315
To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: rrosch, ahmadsamir, kde-frameworks-devel, LeGast00n, cblack
rrosch added a comment.
Hi, sorry for the lack of responses, for some reason I did not receive any of
the notifications except this last one. I will test and comment as soon as I
can. Wishing everyone safety and health too.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org
rrosch added a comment.
Crash:
kf5.kio.kdirmodel: Items emitted in directory QUrl("file:///home/myuser/")
but that directory isn't in KDirModel! Root directory:
QUrl("file:///home/myuser/")
KCrash: Application 'konqueror' crashing...
This happens right after pressing F9 to bri
rrosch added a comment.
> Keep only matters for further calls to openUrl, not the first one. It's
about whether to *add* or *replace* the currently open URL.
> KDirModel takes care of that.
Ah ok, so it's going to do that without me needing to explicitly specify
"Keep"?
>> I coul
rrosch accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27731
To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
rrosch added a comment.
Ok, I found one of the "implications". With
`model->dirLister()->openUrl(m_initURL, KDirLister::Keep);` I can list KIO urls
like `remote:`, `font:`, and `applications:`, but with
`model->openUrl(m_initURL, KDirModel::ShowRoot);` I cannot, and only seems to
display th
rrosch added a comment.
Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had
to change the call in my code that was originally:
model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep);
to
model->openUrl(QUrl::fromLocalFile("/"), KDirM
