Move kde-config to kde4support.

Hi David, Please review it. Thanks, Jignesh move_kde-config.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Patch: Port KDESRCDIR to QFINDTESTDATA.

Hi David, I am able to port all the KDESRCDIR instances to QFINDTESDATA. Compiled and tested. Please review. Thanks, Jignesh QFINDTESTDATA_v3.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mai

Re: Patch: Move kprotocolmanager to kiocore.

Hi David, Here is the first patch which removes QGuiAppliction from kprotocolmanager. Please review it. Thanks, Jignesh On Mon, Feb 11, 2013 at 10:45 PM, David Faure wrote: > On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > > Hi David, > > > > It moves kpro

Patch: Remove kDebug includes from kio/kio

Hi David, I have removed all the kdebug.h includes from kio/kio. Please review it. Thanks, Jignesh remove_kdebug_includes.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Re: Patch: port kError to qError and kFatal to qFatal

Here cmd is int so I haven't made any changes. for listit I used qWarning() followed by abort(). Please review it. On Wed, Jan 9, 2013 at 5:16 PM, David Faure wrote: > On Wednesday 09 January 2013 16:45:08 Jignesh Kakadiya wrote: > > Hi David, > > > > I have ported al

Patch: port kError to qError and kFatal to qFatal

Hi David, I have ported all kError calls to qWarning and kFatal to qFatal in kdelibs/kio/kio directory. Compiles successfully. Please review it. Next patch will be removal of kdebug.h include from kio/kio. Thanks, Jignesh kError_and_kFatal.patch Description: Binary data ___

Patch: port kWarning(*) to qWarning

Hi, I have ported all kWarning calls to qWarning in kdelibs/kio/kio directory. Please review it. Thanks, Jignesh kWarning_to_qWarning.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.or

patch: port KGlobal::findDirectChild to qt5 equivalent findDirect

Hi David, I have ported all the calls which is in kparts. Please review it. Thanks, Jignesh findDirectChild.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-fra

Re: Patch: KGlobal::mainComponent().componentName()

Attached Patch here. On Sun, Jun 17, 2012 at 3:26 PM, Jignesh Kakadiya wrote: > KGlobal::mainComponent().componentName() should be replaced with > QCoreApplication::instance()->applicationName() > > Please Review It. > > Thanks, > Jignesh > KGlobal_mainComponent.pat

Patch: KGlobal::mainComponent().componentName()

KGlobal::mainComponent().componentName() should be replaced with QCoreApplication::instance()->applicationName() Please Review It. Thanks, Jignesh ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/k

Patch: Use kcoreauthorized.h instead of kauthorized.h.

Use of KAuthorized for methods other than *UrlAction, should include kcoreauthorized.h rather than kauthorized.h. Please review it. Thanks, Jignesh kcoreauthorized.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Patch: Use QLatin1String instead of KGlobal::staticQString

Updated patch. -Jignesh On Thu, Jun 14, 2012 at 9:42 PM, Jignesh Kakadiya wrote: > Hi, > > All occurrences of KGlobal::staticQString in kdelibs are removed in favour > of direct usage of QLatin1String. > > Please review it. > > Thanks, > Jignesh > staticQSt

Patch: Use QLatin1String instead of KGlobal::staticQString

Hi, All occurrences of KGlobal::staticQString in kdelibs are removed in favour of direct usage of QLatin1String. Please review it. Thanks, Jignesh staticQString_cleanup.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-framewor

Re: Patch: Fixes KGlobalSettings::documentPath() warnings.

Fixed suggested comments. Local build compiles with no errors. -Jignesh On Mon, Jun 11, 2012 at 5:16 PM, David Faure wrote: > On Monday 11 June 2012 00:34:58 Jignesh Kakadiya wrote: > > Hi, > > > > Attached is the patch which fixes below warning. > > > > k

Patch: Fixes KGlobalSettings::documentPath() warnings.

Hi, Attached is the patch which fixes below warning. kinit.cpp:543:78: warning: ‘static QString KGlobalSettings::documentPath()’ is deprecated (declared at /d/kde/src/5/kdelibs- frameworks/staging/kwidgets/src/utils/kglobalsettings.h:228) [-Wdeprecated- declarations] Please review it. Thanks, J