Re: KCGroups in KDEreview

On Saturday, November 21, 2020 1:38:47 AM CET Albert Astals Cid wrote: > El divendres, 20 de novembre de 2020, a les 14:55:16 CET, Henri Chain va escriure: > > Hello everyone, > > > > KCgroups has been moved to KDEReview ! > > What is that, you ask ? It's a lib

Re: KCGroups in KDEreview

n't have plans to make this a platform independent library but it could be a long term goal. > On Fri, Nov 20, 2020, at 05:55, Henri Chain wrote: > > Hello everyone, > > > > KCgroups has been moved to KDEReview ! > > What is that, you ask ? It's a library that

KCGroups in KDEreview

Hello everyone, KCgroups has been moved to KDEReview ! What is that, you ask ? It's a library that wraps the systemd dbus API to expose a higher-level concept of desktop application and allow control of its system resource usage (CPU, RAM, IO, etc). It relies on the recent ability of plasma to

D28421: Add static method to check start condition

hchain added inline comments. INLINE COMMENTS > davidedmundson wrote in kautostart.h:289 > Added. > https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 I think you added it to the wrong method ;) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28

D28510: [kprocessrunner] Escape hyphen characters in scope names

hchain added a comment. The full systemd escape code is here: https://github.com/systemd/systemd/blob/master/src/basic/unit-name.c#L294 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28510 To: davidedmundson, apol Cc: hchain, kde-frameworks-devel, LeGast00n, cblack, GB

D28421: Add static method to check start condition

This revision was automatically updated to reflect the committed changes. Closed by commit R309:fe5c63b177a1: Add static method to check start condition (authored by hchain). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78864&id=78870 REVISION DET

D28421: Add static method to check start condition

hchain retitled this revision from "Add a new standalone executable to replace X-KDE-Autostart-Condition" to "Add static method to check start condition". hchain edited the summary of this revision. hchain edited the test plan for this revision. REPOSITORY R309 KService REVISION DETAIL https

D28421: Add static method to check start condition

hchain updated this revision to Diff 78864. hchain added a comment. void REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78863&id=78864 REVISION DETAIL https://phabricator.kde.org/D28421 AFFECTED FILES src/services/kautostart.cpp src/servic

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain updated this revision to Diff 78863. hchain added a comment. remove binary REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78848&id=78863 REVISION DETAIL https://phabricator.kde.org/D28421 AFFECTED FILES src/services/kautostart.cpp s

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain added inline comments. INLINE COMMENTS > davidedmundson wrote in kde-systemd-start-condition.cpp:17 > Should it be showHelp(255)? > > Not that we should end up here in the generated case. I intentionally return 0 here to mimic the behavior of KAutostart which returns true if the condit

D28421: Add a new standalone executable to replace X-KDE-Autostart-Condition

hchain created this revision. hchain added reviewers: davidedmundson, broulik, dfaure, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY For systemd autostart generator will add a ExecConditi

D27717: fix min/max entries with dpointer

This revision was automatically updated to reflect the committed changes. Closed by commit R237:f98feb169813: fix min/max entries with dpointer (authored by hchain). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27717?vs=76600&id=76604 REVISION DETAIL http

D27717: fix min/max entries with dpointer

hchain created this revision. hchain added reviewers: meven, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY D27497 was causing cases with dpointer + min/m

D27672: Fix tests after D27497

hchain accepted this revision. hchain added a comment. This revision is now accepted and ready to land. Can confirm this works REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D27672 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-framewor

D27497: Fix code generation for entries with min/max

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d218b93a5350: Fix code generation for entries with min/max (authored by hchain). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76368&id=76371 REVISION DE

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76368. hchain added a comment. add bugzilla REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76317&id=76368 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES autotests/kconfig_compiler/CMakeL

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76317. hchain added a comment. const, change method name, reformat code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75987&id=76317 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES autot

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75987. hchain added a comment. Add reference files for other tests that were impacted REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75985&id=75987 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75985. hchain added a comment. Reduce number of lines in generated test code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75983&id=75985 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75983. hchain added a comment. Yet more style fixes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75982&id=75983 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES autotests/kconfig_compile

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75982. hchain added a comment. Fix Style/whitespace REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75978&id=75982 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES autotests/kconfig_compile

D27496: Fix isImmutable generated property

hchain accepted this revision. hchain added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D27496 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-frameworks-devel, LeGast00

D27497: Fix code generation for entries with min/max

hchain created this revision. hchain added reviewers: meven, crossi, ervin, bport, tcanabrava. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY - When GenerateProperties and Mutators are activated, the