D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

2020-04-15 Thread Frank Fischer
fifr added a comment. Well, the main problem for me is that I do not know what `waitForAnswer` is supposed to to and in which situation it is supposed to be called. The assumptions that I made are the following: - it is called to receive an answer after some kind of command (that should

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

2020-02-13 Thread Frank Fischer
fifr retitled this revision from "Return error instead of aborting when receiving an unexpected answer" to "[RFC] Return error instead of aborting when receiving an unexpected answer". fifr added a reviewer: kiokiio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27385 To

D27385: Return error instead of aborting when receiving an unexpected answer

2020-02-13 Thread Frank Fischer
fifr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fifr requested review of this revision. REVISION SUMMARY If SlaveBase::waitForAnswer receives an unexpected subcommand it aborts by calling qFatal. However, an unexpected subcommand