D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-30 Thread Erik Schilling
ablu abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-30 Thread Erik Schilling
ablu added a comment. Ah, right. If you are using a normal sysroot for system libs, but conan for some libs then it makes sense! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau, kde

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-29 Thread Erik Schilling
ablu added a comment. Sure! Though... How does it come that you do not have SYSROOT set in your case? Won't that break in other cases? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, ko

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-04-29 Thread Erik Schilling
ablu added a comment. The Build worked. So this solves the issue for me! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michael

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-29 Thread Erik Schilling
ablu added a comment. looks good! yours is probably a bit more "CMakeish"! So feel free to continue with that one and close this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau, kd

D29274: ECMGeneratePriFile: make the pri files relocatable

2020-04-29 Thread Erik Schilling
ablu added a comment. My reason is basically the same. Will try this version too. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-29 Thread Erik Schilling
ablu added a comment. Hi @dfaure. It looks pretty much the same and I think it should work for us. I will kick off a build to confirm. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kosseba

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-23 Thread Erik Schilling
ablu added a comment. > Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that i

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu added a comment. The SYSROOT variable should not (directly) impact that. The install directory is configured by ECM_MKSPECS_INSTALL_DIR, which usually will point to /usr/lib/mkspecs/modules/ on Linux. For a cross-compile toolchain it will however be additionally prefixed with separate p

D29096: Prefix includes and libs dir with QT_SYSROOT

2020-04-22 Thread Erik Schilling
ablu created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. ablu requested review of this revision. REVISION SUMMARY If this is not done a cross compilation will attempt to load headers and libs from /usr/ usuall