Re: Split kde-baseapps?

2015-02-07 Thread David Narvaez
On Sun, Feb 1, 2015 at 7:57 AM, David Narvaez wrote: > On Mon, Jan 19, 2015 at 11:13 AM, David Narvaez > wrote: >> On Mon, Jan 19, 2015 at 3:05 AM, David Faure wrote: >>> I thought kio-about was going into kio-extras? >> >> Indeed, I just realized. > > Thi

Re: Split kde-baseapps?

2015-02-01 Thread David Narvaez
On Mon, Jan 19, 2015 at 11:13 AM, David Narvaez wrote: > On Mon, Jan 19, 2015 at 3:05 AM, David Faure wrote: >> I thought kio-about was going into kio-extras? > > Indeed, I just realized. This is now at g...@git.kde.org:clones/kio-extras/narvaez/kio-extras-about Could

Re: Move thumbnail kioslave and thumbcreator service type to kio?

2015-01-19 Thread David Narvaez
On Sun, Jan 18, 2015 at 2:38 PM, David Narvaez wrote: > Coincidentially, I am transplanting a protocol into KIO right now, so > I can do this move also. So this transplant required some heavier porting to KF5 and now I have a couple of questions about how to post this for review. Should I:

Re: Split kde-baseapps?

2015-01-19 Thread David Narvaez
On Mon, Jan 19, 2015 at 3:05 AM, David Faure wrote: > I thought kio-about was going into kio-extras? Indeed, I just realized. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Re: Move thumbnail kioslave and thumbcreator service type to kio?

2015-01-18 Thread David Narvaez
On Sun, Jan 18, 2015 at 9:16 AM, Bhushan Shah wrote: > Thanks, can you do the move? as I have no knowledge of how to preserve > history while doing so and stuff Coincidentially, I am transplanting a protocol into KIO right now, so I can do this move also. David E. Narvaez ___

Re: Split kde-baseapps?

2015-01-18 Thread David Narvaez
On Mon, Jan 5, 2015 at 3:27 AM, David Faure wrote: > AFAIK there are two ways. One where you replay the history using git filter- > branch, there's a wiki page about how to do this (iirc from Alex Merry). This is up at g...@git.kde.org:clones/kio/narvaez/kio-about-protocol Please review everythi

Re: Split kde-baseapps?

2014-11-12 Thread David Narvaez
On Mon, Nov 10, 2014 at 4:46 PM, David Faure wrote: > If it's useful to share it, let's share it, I have no objection to that. How should this be done? Can I just copy things around and post a RR or should be this moved around by one of our git curators to preserve history? David E. Narvaez

Re: Split kde-baseapps?

2014-11-06 Thread David Narvaez
On Sat, Oct 25, 2014 at 3:06 PM, David Narvaez wrote: > It's also used by Rekonq and anything building a web browser using KDE > software, it should really go to kioslave-extras. Any feedback on this? If it will not be moved to kioslave-extras I need to patch Rekonq to stop annoying m

Feedback on KDBusService::activateRequested

2014-11-06 Thread David Narvaez
Hi, After working on the implementation of the unique mode in Rekonq[0], I have some (unsolicited) feedback about the activateRequested slot that I would like to share in case these issues can be addressed: Whenever I use libraries that deal with command line arguments my first question is whethe

Re: Split kde-baseapps?

2014-10-25 Thread David Narvaez
On Fri, Oct 10, 2014 at 5:07 PM, David Faure wrote: > On Thursday 25 September 2014 01:01:27 Aleix Pol wrote: >> - kioslave/about: I guess it should go either to kioslave-extras or >> konqueror itself. I guess it's here because the applications use it, so >> kioslave. > > It's only used by Konquer

Re: KUnitConversion

2014-08-13 Thread David Narvaez
On Wed, Aug 13, 2014 at 1:46 AM, Garret Wassermann wrote: > A library that allows one to define new derived units in terms of > base units and register them with the library would be really cool. > it could be useful for anyone no matter how specialized the field, > rather than having to update th

Re: Enabling Exceptions in CMake

2014-08-11 Thread David Narvaez
On Mon, Aug 11, 2014 at 4:52 AM, Aleix Pol wrote: > Well, you can document it together with the funcion that enables exceptions > at least. OK, documented at https://techbase.kde.org/index.php?title=Development/ECM_SourceIncompatChanges&diff=82951&oldid=82898 David E. Narvaez __

Re: Enabling Exceptions in CMake

2014-08-11 Thread David Narvaez
On Sun, Aug 10, 2014 at 5:03 PM, Aleix Pol wrote: > From kde-modules/KDECompilerSettings.cmake > > # kde_enable_exceptions() > # > # Enables exceptions for C++ source files compiled for the > # CMakeLists.txt file in the current directory and all subdirectories. > > See http://api.kde.org/ecm/kd

Re: KDialog::spacingHint

2014-08-10 Thread David Narvaez
On Sun, Aug 10, 2014 at 11:08 AM, Christoph Feck wrote: > I should add that if the spacingHint() was only needed to get any > spacing at all in a K*Box (which defaulted to zero spacing), then you > can simply remove the code. Q*BoxLayout already does internally call > layoutSpacing(). It was inde

Enabling Exceptions in CMake

2014-08-10 Thread David Narvaez
Hi, I just noticed the old CMake line my project used to enable exceptions on a single file was not working and I dug into the ECM modules to find the correct way to do that. But I don't see exceptions mentioned in the ECM SIC page[0], should that documentation be there? i.e., is this considered a

KDialog::spacingHint

2014-08-10 Thread David Narvaez
Hi, What's the correct way to port away from KDialog::spacingHint? I read the sources of it in KDELibs 4 and replaced it with QApplication::style()->pixelMetric( QStyle::PM_DefaultLayoutSpacing ) is that OK? David E. Narvaez ___ Kde-frameworks-devel m

Porting KDialog::makeStandardCaption

2014-07-25 Thread David Narvaez
Hi, What's the new way to do KDialog::makeStandardCaption[0] withot KDELibs4Support? Thanks. David E. Narvaez [0] http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDialog.html#a765be466448a0212674700a8f843966e ___ Kde-frameworks-devel mail

Re: KIcon -> QIcon and KIconLoader

2014-07-25 Thread David Narvaez
On Fri, Jul 25, 2014 at 5:45 PM, Martin Klapetek wrote: > You can do > > QIcon icon(new KIconEngine(iconName, pointerToIconLoader)); Thanks. I'll update the porting documentation and the porting script. David E. Narvaez ___ Kde-frameworks-devel mailing

KIcon -> QIcon and KIconLoader

2014-07-25 Thread David Narvaez
Hi, The migration script from KIcon to QIcon seems to think every usage of KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon( iconName, pointerToIconLoader ). What do I need to do to port those to QIcon? Thanks. David E. Narvaez ___

Re: KF5 Porting: Installing Icons

2014-07-24 Thread David Narvaez
On Thu, Jul 24, 2014 at 2:35 PM, Alex Merry wrote: > As Jonathan said, yes, you are correct. And, yes, I should really write a > porting script for that. Thanks for the confirmation, I just posted https://git.reviewboard.kde.org/r/119457/ David E. Narvaez

Re: KF5 Porting: Installing Icons

2014-07-23 Thread David Narvaez
On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell wrote: >> # The given icons, whose names must match the pattern:: >> # >> # --. >> >> seems to indicate I need to rename all of the files to remove the >> theme from the prefix. > > Keep the theme name, preferably use hicolor for icons that are a

KF5 Porting: Installing Icons

2014-07-23 Thread David Narvaez
Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS argument

Re: Re: Writing a Frameworks book at Randa

2014-04-12 Thread David Narvaez
On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin wrote: > we might have here a chicken-egg problem. Good API documentation would > significantly help for writing the book. That is if the API documentation is > good someone without deep domain knowledge will be able to write a book about > it. But i

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread David Narvaez
On Fri, Jan 24, 2014 at 7:37 AM, Aleix Pol wrote: > I recreated my build directories and now I'm hitting it too. I guess it a > matter of time that it spreads to the rest of who are building > kde4support... > > I tried with cmake 2.8.12.1 and today's master. I'm on this, will provide my findings

Re: Build failed in Jenkins: kde4support_master_qt5 #31

2014-01-23 Thread David Narvaez
On Wed, Jan 22, 2014 at 3:28 AM, KDE CI System wrote: > In file included from > :45:0: > :168:8: > error: redefinition of ‘struct addrinfo

Re: cyclic dependency kinit - kservice

2013-10-26 Thread David Narvaez
On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens wrote: > Not that I know of, Alex never replied to that I think... What would be a proper fix for this? Separating kbuildsycoca and putting it on top of kinit? David E. Narvaez ___ Kde-frameworks-devel mai

Re: cyclic dependency kinit - kservice

2013-10-26 Thread David Narvaez
On Mon, Oct 21, 2013 at 12:08 PM, Kevin Ottens wrote: > On Monday 21 October 2013 17:01:44 Treeve Jelbert wrote: >> kinit needs kservice and installs KInitMacros.cmake which defines >> kf5_add_kdeinit_executable which is needed by kservice/kbuildsycoca > > Well, spotted, missed that one in the rev

Re: Removing the KFileMetadataWidget

2013-09-30 Thread David Narvaez
On Mon, Sep 30, 2013 at 11:14 AM, Vishesh Handa wrote: > I'm planning on removing KFileMetaDataWidget completely, and marking it as > deprecated in kdelibs4. Applications which still use it (Konversation and > KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api. I'll port