muesli accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
telephant (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29049
To: mbruchert, muesli, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michael
muesli added a comment.
Gets my approval! I assume those symlinks from 'com.fribbledom.telephant.svg'
are intentional to match the appstream ID?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D29049
To: mbruchert, muesli, #vdg
Cc: kde-frameworks-devel, LeGast00
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:a1c973c01ece: Use exposed DBus methods to switch activities
in CLI (authored by muesli).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24401?vs=67281&id=75776
REV
muesli added a comment.
@ivan @ngraham Ok, with 5.18 out I think we can finally review this one :-)
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D24401
To: muesli, ivan
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns
muesli added a comment.
Actually I'm mistaken, we can't merge this just yet. We'll still need to wait
for the Plasma 5.18 release.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D24401
To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
muesli added a comment.
@ivan Do you think we can merge this now?
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D24401
To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
muesli added a comment.
Careful: we must _not_ land this before the next Plasma release.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D24401
To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
muesli created this revision.
muesli added a reviewer: ivan.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
muesli requested review of this revision.
REVISION SUMMARY
Since https://phabricator.kde.org/D22381 has landed kactivitymanagerd
now exposes methods
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:c450f09e8921: Simplify previous-/nextActivity code in
kactivities-cli (authored by muesli).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22370?vs=61499&id=61502
muesli added a reviewer: ivan.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D22370
To: muesli, ivan
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
muesli created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
muesli requested review of this revision.
REVISION SUMMARY
Removed unnecessary bool found and directly return from inner loop.
REPOSITORY
R6 KActivities
BRANCH
kactivities-cli
11 matches
Mail list logo